DVR deployment is broken

[Oleg Bondarev]

Trace in nailgun when deploying with neutron DVR enabled:

2015-09-01 13:02:54.766 ERROR [7f9e4987d740] (manager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/nailgun/task/manager.py", line 58, in _call_silently
    to_return = method(task, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/nailgun/task/task.py", line 164, in message
    orchestrator_graph, task.cluster, nodes)
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 575, in serialize
    cluster, nodes, ignore_customized=ignore_customized)
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 82, in serialize
    cluster, node_group))
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 91, in serialize_generated
    nodes = self.serialize_nodes(nodes)
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 238, in serialize_nodes
    serialized_nodes.append(self.serialize_node(node, role))
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 450, in serialize_node
    DeploymentHASerializer61, self).serialize_node(node, role)
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/deployment_serializers.py", line 258, in serialize_node
    node_attrs.update(net_serializer.get_node_attrs(node))
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/base_serializers.py", line 199, in get_node_attrs
    return cls.network_provider_node_attrs(node.cluster, node)
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/neutron_serializers.py", line 64, in network_provider_node_attrs
    'network_scheme': cls.generate_network_scheme(node, networks),
  File "/usr/lib/python2.6/site-packages/nailgun/orchestrator/neutron_serializers.py", line 1003, in generate_network_scheme
    if is_public and netgroups['public'].get('gateway'):
KeyError: 'public'

this is a regression from commit 1158c2eddbfaae492b467e94ca9fbbec9ce1a23a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219316

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219316
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=eb7d94b53fae99a56435664c8255ab77af18e3fb
Submitter: Jenkins
Branch: master

commit eb7d94b53fae99a56435664c8255ab77af18e3fb
Author: Oleg Bondarev <email address hidden>
Date: Tue Sep 1 18:23:48 2015 +0300

    Neutron Serializer 7.0: don't set gateway for br_ex without ip address

    When neutron DVR is enabled compute nodes should have public access but
    don't require IP address set on br-ex. In this case no gateway should be
    set on br-ex as well.

    Closes-Bug: #1491023
    Co-Authored-By: Alexander Kislitsky <email address hidden>
    Change-Id: I31de7dc93f22f275d8b7b2dacbd97f6c98902604

[Liubov Efremova (lefremova)]

Verified on: fuel-7.0-286-2015-09-07_03-14-53.iso