Tech Debt: bay_conductor hard-coded server_type to 'vm'

Bug #1491003 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Vilobh Meshram

Bug Description

See Adrian comment in the following review under patchset #7

https://review.openstack.org/#/c/218582/7

We need to fix the hard-coded 'vm' at the file magnum/conductor/handlers/bay_conductor.py

Tags: tech-debt
hongbin (hongbin034)
tags: added: tech-debt
Changed in magnum:
assignee: nobody → Vilobh Meshram (vilobhmm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235028

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/235028
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=798fc51c47d54ed8d48e5870dc40d655e95dc81a
Submitter: Jenkins
Branch: master

commit 798fc51c47d54ed8d48e5870dc40d655e95dc81a
Author: Vilobh Meshram <email address hidden>
Date: Wed Oct 14 17:22:51 2015 -0700

    Create BayModel with provided(VM/BM) server type

    In its current state of art, the Baymodel is created
    with only "VM" server type. This value is hardcoded in the
    code and a tech debt bug was filed to clean it off. Also
    this feature can be useful to allow bay model creation with
    various server type like virtual machines, baremetal etc.

    Client side changes will be provided as part of seperate
    patch.

    Partial-Bug: #1491003

    Change-Id: I8981031d097fc41c94ad509c7b090f0a57a90525

Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Revision history for this message
yatin (yatinkarel) wrote :

I think, this is already fixed in master. This can be closed, if required for magnumclient then new bug can be created

Changed in magnum:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.