ESLint glob pattern not matching all files for lint

Bug #1490704 reported by Rajat Vig
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Rajat Vig

Bug Description

The file glob pattern in package.json

*/static openstack_dashboard/dashboards/*/static

is not running eslint on the openstack_dashboard/static files.

The files in that package have unaddressed warnings.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219010

Changed in horizon:
assignee: nobody → Rajat Vig (rajatv)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/219010
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=40899b8481222eae67038d4a8d685be971b1434e
Submitter: Jenkins
Branch: master

commit 40899b8481222eae67038d4a8d685be971b1434e
Author: Rajat Vig <email address hidden>
Date: Mon Aug 31 12:52:10 2015 -0700

    ESLint glob pattern not matching files for lint

    The file glob pattern in package.json

    */static openstack_dashboard/dashboards/*/static

    has been changed to openstack_dashboard/static and
    horizon/static as only then does it run lint on the
    openstack_dashboard folder.

    Fixed issues in files in openstack_dashboard that
    have unaddressed warnings.

    Change-Id: I1ae1346281f028821afae159d471e3e87b2d8d6d
    Closes-Bug: #1490704

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.