Few corrections are needed in method and parameter descriptions

Bug #1490379 reported by vikas choudhary
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
vikas choudhary

Bug Description

file: ./magnum/conductor/template_definition.py
class TemplateDefinition(object):

def get_params(self, context, baymodel, bay, **kwargs):
        """Pulls template parameters from Baymodel and Bay.

        :param context: Context to pull template parameters from
        :param baymodel: Baymodel to pull template parameters from
        :param bay: Bay to pull template parameters from
        :param extra_params: Any extra params to provide to the template

Can be corrected to :

 """Pulls template parameters from Baymodel and/or Bay.

        :param context: Context to pull template parameters for
        :param baymodel: Baymodel to pull template parameters from
        :param bay: Bay to pull template parameters from
        :param extra_params: Any extra params to be provided to the template

Changed in magnum:
assignee: nobody → vikas choudhary (choudharyvikas16)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/218715

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/218715
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=9d790ff8535e71d6ec9f6993a2730ef3249515a4
Submitter: Jenkins
Branch: master

commit 9d790ff8535e71d6ec9f6993a2730ef3249515a4
Author: Vikas Choudhary <email address hidden>
Date: Mon Aug 31 09:12:32 2015 +0530

    Fix method and parameter descriptions

    Method and parameter descriptions are being corrected for typo
    mistakes and increase readability. In parameter 'context' description,
    it should be 'for' instead of 'from'. Similar few other typos are
    being addressed.

    Change-Id: I6ff2072bf9dcd5ee2414c8b6d000aa155ee29be0
    Closes-Bug: #1490379

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.