Need hacking rules for translations

Bug #1490194 reported by Davanum Srinivas (DIMS)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Low
Vivek Jain

Bug Description

We added some hacking check rules in bug:
https://bugs.launchpad.net/magnum/+bug/1465895

Nova has a bunch of more check rules which will be useful for us:
http://git.openstack.org/cgit/openstack/nova/tree/nova/hacking/checks.py

We should port and use those additional rules.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in magnum:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Davanum Srinivas (dims) (<email address hidden>) on branch: master
Review: https://review.openstack.org/218536

Changed in magnum:
status: In Progress → New
assignee: Davanum Srinivas (DIMS) (dims-v) → nobody
Revision history for this message
vikas choudhary (choudharyvikas16) wrote :

What's next on this Dims? Why did you abandoned review? Are you planning to push changes in common liberty?

Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Changed in magnum:
assignee: nobody → Vivek Jain (vivek-jain-openstack)
Revision history for this message
yatin (yatinkarel) wrote :

@Vivek, are you working on this, if not i can start working on it.

Revision history for this message
Vivek Jain (vivek-jain-openstack) wrote :

@yatin, Hi yatin, I will be submitting fix this week. Thanks!

Revision history for this message
yatin (yatinkarel) wrote :

Ok, Thanks

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/347517

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/347517
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=28c8014ff05b569ed229b4cb2f77edb5869934ba
Submitter: Jenkins
Branch: master

commit 28c8014ff05b569ed229b4cb2f77edb5869934ba
Author: Vivek Jain <email address hidden>
Date: Fri Jul 29 23:08:22 2016 +0530

    Add hacking rule for explicit import of _ function

    Change-Id: Id0c1610f0b6353a43341f704e0b4b00bd04828bb
    Closes-bug: #1490194

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.