No container status constant for 'Unknown'

Bug #1489996 reported by Ryan Rossiter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Ryan Rossiter

Bug Description

It looks like when an exception gets raised when getting the containers, the API is setting the status of the container to be 'Unknown'. (see https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/container.py#L294)

'Unknown' is not defined in https://github.com/openstack/magnum/blob/master/magnum/objects/container.py#L22-L26 as a possible status. This should be added to those constants and the API should be using the constant instead of the hard-coded string.

Ryan Rossiter (rlrossit)
Changed in magnum:
assignee: nobody → Ryan Rossiter (rlrossit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/218415
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=cac328d1c431f61bb81ea607d35859599b7ac6b5
Submitter: Jenkins
Branch: master

commit cac328d1c431f61bb81ea607d35859599b7ac6b5
Author: Ryan Rossiter <email address hidden>
Date: Fri Aug 28 18:39:19 2015 +0000

    Add UNKNOWN constant to container statuses

    The container API would set the status of a container to 'Unknown' if
    there was an exception when retrieving the container. This status should
    be contained as a constant (as with all other container constants). This
    change adds an UNKNOWN constant to the container object module, and
    changes the API to use that constant instead of the hard-coded string.

    Change-Id: I7cec02e2e8b8619bd2fcba4ba867ec8b21ad5afe
    Closes-Bug: #1489996

Changed in magnum:
status: New → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.