Remove external package, service, class references from manifests

[Bogdan Dobrelya]

When deploying classes foo (init.pp) and foo::bar (bar.pp) from PO modules in separate puppet runs, there should be no external packages, services, classes references, like Service[foo], Package[foo] for some class foo::bar. At least for packages and services, this issue may be resolved
with <||> collectors instead.

Not sure how to resolve this for Class[foo] references from a class foo::bar

[Bogdan Dobrelya (bogdando)]

To be more clear, here is example:
If user wants to deploy by separate puppet runs the following classes:
class {'neutron':}, class {'neutron-server':}, class {'neutron::plugins::ml2':} class { 'neutron::agents::ml2::ovs':}

she will have to 'unbind' external Class['Neutron'] reference with very ugly hack like this:
# Remove external class dependency and restore required ones
Service <| title == 'neutron-ovs-agent-service' |> {
  require => undef
}
Neutron_plugin_ml2<||> ~> Service['neutron-ovs-agent-service']
File['/etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini'] ~>
Service<| title == 'neutron-ovs-agent-service' |>

[Bogdan Dobrelya (bogdando)]

Addressed by https://review.openstack.org/218797

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218825

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/218797
Reason: Abandoning until times then bp atomic-classes-orchestration will be accepted

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/218825
Reason: Abandoning until times then bp atomic-classes-orchestration will be accepted