Create ICMP security group rule with type but no code will success

[Dongcan Ye]

If the user create ICMP security group rule, specifing the required ICMP type, but no code, it will success.
I think neutron-server should raise an error here.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218250

[yujie (16189455-d)]

I use kilo to test, if assign ICMP type without code, it returns "The ICMP code is invalid".

[Dongcan Ye (hellochosen)]

In master assign like this: type: 0 code:-1, it will success. But I think this should raise an error.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dongcan Ye (<email address hidden>) on branch: master
Review: https://review.openstack.org/218250