Ubuntu bootstrap image was not built during deploy Fuel master node

[Dennis Dmitriev]

Fuel master node is failing to make Ubuntu bootstrap image, but deploy of master node is not failing because of using ' || true ' in bash script.

        Scenario:
            1. Install Fuel master node
            2. Choose Ubuntu bootstrap on master node
            3. Bootstrap slaves
            4. Verify bootstrap on slaves

Expected result: slaves bootstrapped with Ubuntu bootstrap image.

Actual result: slaves bootstrapped with default Ubuntu bootstrap image, without SSH keys, without default password for user 'root' (see screenshot attached).

# From the /var/log/puppet/bootstrap_admin_node.log :
/usr/local/sbin/bootstrap_admin_node.sh: line 188: centos: command not found

# From the bootstrap_admin_node.sh: line 188:
if "`get_bootstrap_flavor`" = "ubuntu"; then #### Incorrect comparison
    build_ubuntu_bootstrap || true #### '|| true' causes broken
                                   #### Fuel master installation
                                   #### without any notification
fi

# From the Fuel master node:
[root@nailgun log]# get_bootstrap_flavor
bash: get_bootstrap_flavor: command not found

[root@nailgun log]# build_ubuntu_bootstrap
bash: build_ubuntu_bootstrap: command not found

[Dennis Dmitriev (ddmitriev)]

ISO version: {
 "build_id": "2015-08-27_18-45-15",
 "build_number": "246",
 "auth_required": true,
 "fuel-ostf_sha": "83048d68609854324ceeaf04242e68d658cfb55d",
 "fuel-library_sha": "800b28137e131334d447c353db213b1d43f9bedb",
 "nailgun_sha": "cbe7dcab16fbdacaa8e80e36a925191e7986a068",
 "openstack_version": "2015.1.0-7.0",
 "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd",
 "fuel-agent_sha": "8844dc5964fb197b64525f04b6ec15cbbcfe44f0",
 "api": "1.0",
 "python-fuelclient_sha": "9643fa07f1290071511066804f962f62fe27b512",
 "astute_sha": "53c86cba593ddbac776ce5a3360240274c20738c",
 "fuelmain_sha": "8ead1228c637ba80e7dead37dfe09d85f00b7c29",
 "feature_groups": [
  "mirantis"
 ],
 "release": "7.0",
 "release_versions": {
  "2015.1.0-7.0": {
   "VERSION": {
    "build_id": "2015-08-27_18-45-15",
    "build_number": "246",
    "fuel-library_sha": "800b28137e131334d447c353db213b1d43f9bedb",
    "nailgun_sha": "cbe7dcab16fbdacaa8e80e36a925191e7986a068",
    "fuel-ostf_sha": "83048d68609854324ceeaf04242e68d658cfb55d",
    "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd",
    "fuel-agent_sha": "8844dc5964fb197b64525f04b6ec15cbbcfe44f0",
    "api": "1.0",
    "python-fuelclient_sha": "9643fa07f1290071511066804f962f62fe27b512",
    "astute_sha": "53c86cba593ddbac776ce5a3360240274c20738c",
    "fuelmain_sha": "8ead1228c637ba80e7dead37dfe09d85f00b7c29",
    "feature_groups": [
     "mirantis"
    ],
    "release": "7.0",
    "openstack_version": "2015.1.0-7.0",
    "production": "docker"
   }
  }
 },
 "production": "docker"
}

[Alexei Sheplyakov (asheplyakov)]

Works as designed - Ubuntu bootstrap is not supposed to be built during the master node deployment unless the user has explicitly enabled it.

[Alexei Sheplyakov (asheplyakov)]

> [root@nailgun log]# build_ubuntu_bootstrap
> bash: build_ubuntu_bootstrap: command not found

build_ubuntu_bootstrap is a function defined in bootstrap_admin_node.sh script

[Alexei Sheplyakov (asheplyakov)]

Also a failure to build an image is not supposed to terminate the master node deployment - the user can login to the master node and

a) either retry building the Ubuntu based image:

  fuel-bootstrap-image-set ubuntu

b) switch to the CentOS based one:

 fuel-bootstrap-image-set centos

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/218236

[Nastya Urlapova (aurlapova)]

Alexey, it is sad that it works so by default. User get an inoperable environment, without some notification. If some functionality isn't work correct it should be visible for other product functionality and users.

[Alexei Sheplyakov (asheplyakov)]

There's indeed a bug in the script, however the current behavior is correct anyway

[Dennis Dmitriev (ddmitriev)]

Sure, building Ubuntu image was moved from Fuel master node deploying to the 'fuel-bootstrap-image-set ubuntu' manual command.
Moving this bug to invalid. Opened another bug about SSH keys absence in Ubuntu bootstrap: https://bugs.launchpad.net/fuel/+bug/1489882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218236
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=0e54d68392b359bc122e5bbba9249c729eeaf579
Submitter: Jenkins
Branch: master

commit 0e54d68392b359bc122e5bbba9249c729eeaf579
Author: Alexey Sheplyakov <email address hidden>
Date: Fri Aug 28 14:51:19 2015 +0300

    Actually build Ubuntu based bootstrap if it's enabled

    Change-Id: Ic3c4ca2f48d7532aa28bc0354e8d02dce24274e5
    Related-Bug: #1489834