regression in neutron_agents in /docker

[Steven Dake]

[sdake@bigiron kolla]$ sudo docker exec neutron_agents cat /var/log/supervisor/neutron-dhcp-agent-stdout---supervisor-4IZ1k3.log
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly

[Sam Yaple (s8m)]

CONFIG_STRATEGY_COPY_ONCE was changed to COPY_ONCE or COPY_ALWAYS

update your globals.yml

[Sam Yaple (s8m)]

apologies! i forgot we violate dry in the agents container!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218084
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=399117b27ab35d17fd216a2ae2f391336b47a6a9
Submitter: Jenkins
Branch: master

commit 399117b27ab35d17fd216a2ae2f391336b47a6a9
Author: Sam Yaple <email address hidden>
Date: Fri Aug 28 04:29:22 2015 +0000

    Fix neutron-agents regression

    Change-Id: I01220077d8d25db5f69802ad27e745d90826d69b
    Closes-Bug: #1489664

[Steven Dake (sdake)]

This problem still exists in master. I pushed my neutron agents container about 25 minutes ago with git commit:
730276aaf96cc6915b0fc4b2d08e366c7568338e

[Steven Dake (sdake)]

Here is the log:

[sdake@bigiron kolla]$ docker exec neutron_agents cat /var/log/supervisor/neutron-dhcp-agent-stdout---supervisor-7hQWoD.log
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly
$KOLLA_CONFIG_STRATEGY is not set properly

[Sam Yaple (s8m)]

Im not sure how sdake, but you copied old files when you did the scripts move from docker/common to the templates directory.

https://github.com/stackforge/kolla/commit/ce86de9915d24f3a3dc7688ff66a536b6adb780b

This is worrying and I would appreciate it you could audit for any other regressions that would have been introduced.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218682
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=f2b92929732f10dfa6f1eaeb742d775824a8a840
Submitter: Jenkins
Branch: master

commit f2b92929732f10dfa6f1eaeb742d775824a8a840
Author: Steven Dake <email address hidden>
Date: Sun Aug 30 12:42:30 2015 -0700

    Fix KOLLA_CONFIG_STRATEGY in neutron agents

    The change from:
    I01220077d8d25db5f69802ad27e745d90826d69b

    In some way was lost by the gerrit. This patch just basically
    redoes that work so the neutron agents will work properly.

    Change-Id: I92ac1b8601d145a0722b37eda937ee2baac7a7c5
    Closes-Bug: #1489664