[librarian] update_modules.sh does not update a module if the folder exists but the contents has been removed

[Alex Schultz]

If you are using librarian in fuel-library and you remove the contents of one of the librarian managed modules, rerunning update_modules.sh does not results in the module being pulled down again or being git reset back to the version we want.

Steps to reproduce
1. git clone https://github.com/stackforge/fuel-library.git
2. cd fuel-library/deployment
3. ./update_modules.sh
4. ls -al puppet/stdlib/
5. rm -rf puppet/stdlib/*
6. ./update_modules.sh
7. ls -al puppet/stdlib/

Expected Results:
The stdlib module should be the version specified in the Puppetfile.

Actual Results:
The stdlib module is still missing.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/217823

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/217823
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=64a0ccc479ca67325ffe9ccaa5496bd562c6df50
Submitter: Jenkins
Branch: master

commit 64a0ccc479ca67325ffe9ccaa5496bd562c6df50
Author: Alex Schultz <email address hidden>
Date: Thu Aug 27 12:09:23 2015 -0500

    Add module reset logic for librarian

    This change adds the ability to do a reset or an update with the
    updates_modules.sh script. The reset will do a git reset on the upstream
    module if there are any manual changes. The update will do a librarian
    update which will checkout the version specified in the Puppetfile.
    These changes allow for better development testing as a developer can
    test manual changes and version changes via the update_modules.sh
    script. Additionally the fuel_noop_tests.rb script has been updated to
    support the reset flag for developer testing.

    Change-Id: Ib21b3ea210b554e1f58bb7a80453989ba8206104
    Closes-Bug: 1489542

[Dmitry Belyaninov (dbelyaninov)]

Verified on iso #567

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "567"
  build_id: "567"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "33634ec27be77ecfb0b56b7e07497ad86d1fdcd3"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

Also there is one comment:
may be we need to move "install command" after "update command"?