Test cases fail due to mismatch in verification of ovs flows.

[neethi shashidhar]

Tests cases: networking_vsphere.tests.scenario.test_security_groups_basic_ops_esx.OVSvAppSecurityGroupTestJSON.test_udp_security_group_rule_with_port_range , networking_vsphere.tests.scenario.test_security_groups_basic_ops_esx.OVSvAppSecurityGroupTestJSON.test_create_security_group_rule_with_specified_tcp_port_range fail with the error :

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "networking_vsphere/tests/scenario/test_security_groups_basic_ops_esx.py", line 307, in test_udp_security_group_rule_with_port_range
        segment_id, mac_addr, '22', net_id)
      File "networking_vsphere/tests/scenario/manager.py", line 868, in _dump_flows_on_br_sec
        self.assertIn('tp_dst=' + str(port), output_list)
      File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 356, in assertIn
        self.assertThat(haystack, Contains(needle), message)
      File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 435, in assertThat
        raise mismatch_error
    testtools.matchers._impl.MismatchError: 'tp_dst=22' not in ' cookie=0xa304fa80638998b6, duration=11.265s, table=0, n_packets=0, n_bytes=0, idle_age=11, priority=20,udp,in_port=2,dl_vlan=7,dl_dst=fa:16:3e:24:15:7e,nw_src=16.112.0.2,tp_src=67,tp_dst=68 actions=resubmit(,2),output:1\n'

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "networking_vsphere/tests/scenario/test_security_groups_basic_ops_esx.py", line 329, in test_create_security_group_rule_with_specified_tcp_port_range
        mac_addr, key, net_id)
      File "networking_vsphere/tests/scenario/manager.py", line 868, in _dump_flows_on_br_sec
        self.assertIn('tp_dst=' + str(port), output_list)
      File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 356, in assertIn
        self.assertThat(haystack, Contains(needle), message)
      File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 435, in assertThat
        raise mismatch_error
    testtools.matchers._impl.MismatchError: 'tp_dst=20' not in ' cookie=0x4a26dfad92ad4384, duration=10.834s, table=0, n_packets=0, n_bytes=0, idle_age=10, priority=20,tcp,in_port=2,dl_vlan=7,dl_dst=fa:16:3e:24:e4:24,tp_dst=23 actions=resubmit(,2),output:1\n'

[Shuquan Huang (shuquan)]

I can't find this file "test_security_groups_basic_ops_esx.py" in current tempest code.

[prabhu murthy (prabhm)]

Added fix for verification of flows when there is no match

Fixed in below patch set
https://review.openstack.org/#/c/214004/

[OpenStack Infra (hudson-openstack)]

Change abandoned by prabhu murthy (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/214051
Reason: I will cherry pick from master

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214004
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=229efddfd0258c6bb62f1acd4442cf4ac4679c3d
Submitter: Jenkins
Branch: master

commit 229efddfd0258c6bb62f1acd4442cf4ac4679c3d
Author: prabhm <email address hidden>
Date: Mon Aug 17 22:35:30 2015 -0700

    Fixed the scenario test case for port/flow deletion

    1) Added cleanup of neutron port which user created.
       User created port was not getting deleted after the test run.

    2) Added fix for verification of flows when there is no match.
       It was not able to catch the Exception during no match
       for the flows.

    Closes-Bug: 1489312
    Closes-Bug: 1489297

    Change-Id: I416499b271372aa941b0fba4472f13b7739b5810

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222980
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=994a09977855b4b996bb181a28645bd817523a39
Submitter: Jenkins
Branch: stable/kilo

commit 994a09977855b4b996bb181a28645bd817523a39
Author: prabhm <email address hidden>
Date: Mon Aug 17 22:35:30 2015 -0700

    Fixed the scenario test case for port/flow deletion

    1) Added cleanup of neutron port which user created.
       User created port was not getting deleted after the test run.

    2) Added fix for verification of flows when there is no match.
       It was not able to catch the Exception during no match
       for the flows.

    Closes-Bug: 1489312
    Closes-Bug: 1489297

    Change-Id: I416499b271372aa941b0fba4472f13b7739b5810
    (cherry picked from commit 229efddfd0258c6bb62f1acd4442cf4ac4679c3d)