ware x is missing and mine exhausted

[kaputtnik]

In early state of game a player may not produce as many food and beverage to fill the stock of mines. So often the tooltip of exhausted mines says "Did not start mining, because ware x is missing". The tooltip "Mine exhausted" is set rarely, but in this state of game this message is much important than "ware x is missing".

It would be nice if the messages gets combined, like "No resources and no food in the mine to produce ore".

See https://wl.widelands.org/forum/topic/1788/ for discussion.

[Toni Förster (stonerl)]

My naive idea was to not execute this:

https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/map_objects/tribes/production_program.cc#L919

when the current overlay is out_of_resource_title. But I have no clue how to get the current overlay.

Pseudo-Code incomming:

if (overlay != out_of_resource_title){
    ps.set_production_result(result_string);
}

Does ps.production_result() get me there?

@hessenfarmer what do you think

[Toni Förster (stonerl)]

ps.production_result() just outputs the translated text.

[hessenfarmer (stephan-lutz)]

My idea was quite similar:
checking whether the highpriority Message was set / send and supressing the line identified by you.
From a quick look ps.production_result should be the correct method.

so this would result in something like

if (!ps.production_result == descr().out_of_resource_heading()) {
    ps.set_production_result(result_string);
}

However I am not sure whether this will be enough cause some other code in the mines could trigger either ps.set_production_result() or ps.unnotify_player

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/2027