Confusing description and title when adding or editing institution

[Jono M]

When adding or editing an institution (from Administration -> Institutions), the page title is still "Institutions". This needs to be changed to something more descriptive to be properly accessible.

In addition, when adding an institution the <h1> at the top of the page still reads "Manage institutions", making screen reader users especially think that the page has not changed.

Affects latest master

[Kristina Hoeppner (kris-hoeppner)]

To test this one:
1. Log in as site admin
2. Go to "Administration menu".
3. Go to "Institutions".
4. Go to "Settings". That is the first issue mentioned where we used to say "Institutions". Now it's "Settings".
5. Add an institution.
6. Look at the page title. I think this might still be a problem as it only reads "Administer institutions".
7. Give your institution a title.
8. Save.
9. Go back to manage the institution. The title should now include the institution title and the " |Administer institutions".

[Kristina Hoeppner (kris-hoeppner)]

From Julius:

Adding an institution:
* page title is still Institutions. Recommended page title is "Add institution"
* the <h1> at the top of the page reads "Administer institutions". There is an "Add institution" H2 below the H1
* I am not sure if the H2 was recently added, but it does provide clearer description of the form on the main content, so the specific H1 / H2 item is no longer an issue

Editing an institution
* page title is still Institutions. Recommended page title is "Edit institution"
* Recommended H1 is Edit institution [institution name]

[Dianne Tennent (dianne-t)]

Hi there,
Currently all views of institutions.php have the same h1 heading.

The overview page h1 can remain as 'Administer Institutions'

Proposed changes as follows:

1. Adding an institution: To address the problem for non-sighted users to know that the page has changed, we could change the h1 to 'Add', followed by the h2 'Add institution' (To avoid repeating 'Add institution')

2. Editing an institution: To address the problem for non-sighted users to know that the page has changed, we could change the h1 to 'Edit institution'

Please see attached screenshots with examples of this.

[Kristina Hoeppner (kris-hoeppner)]

I think it would be better not have 'Add institution' in the form as heading but just have an h1 with 'Add institution' like we have for editing an institution. There we don't have doubled up heading either.

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12218

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/12218
Committed: https://git.mahara.org/mahara/mahara/commit/d0608c6fdddee1e2cf5199efa37e71089bfbc025
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit d0608c6fdddee1e2cf5199efa37e71089bfbc025
Author: Dianne Tennent <email address hidden>
Date: Tue Nov 2 09:05:42 2021 +1300

A11Y Bug 1489256: differentiate headings

Differentiate headings in each page view
when administering institutions to help
non-sighted users

Change-Id: Idd08a60b03b925b87c1f3d269ac04e21d0aadbf8