heat-manage script encrypts default parameters

Bug #1489157 reported by Pratik Mallya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Randall Burt

Bug Description

If the parameters are specified as default, then they are not sensitive and should not be encrypted. This is because the default parameters are visible and accessible in the raw_template entry for the template.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217377

Changed in heat:
assignee: nobody → Pratik Mallya (pratik-mallya)
status: New → In Progress
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

See my review comment

Changed in heat:
status: In Progress → Invalid
Changed in heat:
status: Invalid → Triaged
importance: Undecided → Medium
milestone: none → liberty-3
Changed in heat:
status: Triaged → In Progress
description: updated
Changed in heat:
milestone: liberty-3 → liberty-rc1
Changed in heat:
milestone: liberty-rc1 → next
Revision history for this message
Pratik Mallya (pratik-mallya) wrote :
Changed in heat:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Pratik Mallya (<email address hidden>) on branch: master
Review: https://review.openstack.org/217377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242185

Changed in heat:
status: Invalid → In Progress
Changed in heat:
assignee: Pratik Mallya (pratik-mallya) → Randall Burt (randall-burt)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/242185
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=535744b4ca650bb44cc5e207e68d9ffb9b7c5a3a
Submitter: Jenkins
Branch: master

commit 535744b4ca650bb44cc5e207e68d9ffb9b7c5a3a
Author: Pratik Mallya <email address hidden>
Date: Wed Aug 26 15:26:28 2015 -0500

    Don't encrypt default parameters in heat-manage encrypt script

    If a parameter has a default value, that must mean that its
    not sensitive enough to be hidden. So don't hide it by encryption.

    Change-Id: Iec209ba6f6778f728a7938b2ab1fd8b4c5b69bd0
    Closes-Bug: #1489157
    Closes-Bug: #1488679

Changed in heat:
status: In Progress → Fix Released
Changed in heat:
milestone: next → newton-1
milestone: newton-1 → mitaka-rc1
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0rc1

This issue was fixed in the openstack/heat 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.