the content of the msg in the file "/ironic/api/controllers/v1/types.py" is incorrect

Bug #1488776 reported by gaoxiaoyong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
gaoxiaoyong

Bug Description

I'm checking the source of the Ironic.
when I checked the following file:
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/types.py

I find that the content of the L265 is following:
===method name is validate===
L265 msg = _("'add' and 'replace' operations needs value")

Because 'add' and 'replace' are two operations, the verb of the "needs" should be "need".
So, the correct content is following:
===method name is validate===
L265 msg = _("'add' and 'replace' operations need value")

End user can see this content, I suggest this issue should be revised.

Changed in ironic:
assignee: nobody → gaoxiaoyong (gaoxiaoyong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217007

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Low
Changed in ironic:
assignee: gaoxiaoyong (gaoxiaoyong) → Ramakrishnan G (rameshg87) (rameshg87)
Changed in ironic:
assignee: Ramakrishnan G (rameshg87) (rameshg87) → gaoxiaoyong (gaoxiaoyong)
Revision history for this message
venkatamahesh (venkatamaheshkotha) wrote :

Hi gaoxiaoyong,

there is another spelling mistake in that file.

def mandatory_attrs():
        """Retruns a list of mandatory attributes.

retruns ==> returns

Thanks
mahesh

tags: added: low-hanging-fruit
Changed in ironic:
assignee: gaoxiaoyong (gaoxiaoyong) → John L. Villalovos (happycamp)
Changed in ironic:
assignee: John L. Villalovos (happycamp) → gaoxiaoyong (gaoxiaoyong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/217007
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=e31daa1e681d3957c8c499dd3406f6bebae7d94d
Submitter: Jenkins
Branch: master

commit e31daa1e681d3957c8c499dd3406f6bebae7d94d
Author: gaoxiaoyong <email address hidden>
Date: Thu Aug 27 03:15:22 2015 +0000

    Fix minor spelling/grammar errors

    Revise "needs value" to "need a value" in "/ironic/api/controllers/v1/types.py"

    Closes-Bug: #1488776
    Change-Id: I3dd1db0bf5c02b6a8d824aca5016057180306340

Changed in ironic:
status: In Progress → Fix Committed
Changed in ironic:
milestone: none → 4.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.