status reason is not updated on failure

[Stanislaw Pitucha]

After bay creation fails, the result from bay-show is:

| status | CREATE_FAILED |
| uuid | 8ca7a574-e861-492d-bd80-8bef9c551e27 |
| status_reason | Stack CREATE started |

But that status_reason is meaningless in this situation.

[bharaththiruveedula (bharath-ves)]

@stanislaw-pitucha, I have tried to reproduce the bug, by giving wrong keypair name in baymodel. And then I triedto bay-create, it failed. But I got expected result in status_reason like "Resource Failed: invalid keypair name (test1)" in both bay-show <id> and heat stack-show <id>. I think we can close this bug.

[Stanislaw Pitucha (stanislaw-pitucha)]

Was this a recent change? I tried with devstack/magnum from the day the issue was raised.
My error was specifically a timeout from the master instance notification - curl failed to report success from the node.

[bharaththiruveedula (bharath-ves)]

I have tried in the latest code.

[Peiyu Lin (mathspanda)]

@bharaththiruveedula, this bug can be reproduced by setting a relatively smaller max_attempts value in bay_conductor.py, for example setting default value 2000 to 10.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/217729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/217729
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=235877bebc2a55f072d96395e79c6a45df9144c3
Submitter: Jenkins
Branch: master

commit 235877bebc2a55f072d96395e79c6a45df9144c3
Author: mathspanda <email address hidden>
Date: Thu Aug 27 21:57:31 2015 +0800

    Sync bay status reason in periodic task

    In periodic task, when bay status is found to be different with
    corresponding stack, or the corresponding stack cannot be found in
    heat, status reason should be synced as well as status. Otherwise,
    status reason will be meaningless in some situation.

    Change-Id: I27d6a7ecb0c74bd4d4a2bb2bfcd81d7632cd2147
    Closes-Bug: #1488709