FakeRing does fake get_part anymore
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Low
|
Aniruddha Singh Gautam |
Bug Description
This is related to the fix for lp bug #1335581
I think eventually the FakeRing behavior got dropped in I8bfc388a04eff6
But the comment remains:
{{{
class FakeRing(Ring):
def __init__(self, replicas=3, max_more_nodes=0, part_power=0,
"""
:param part_power: make part calculation based on the path
If you set a part_power when you setup your FakeRing the parts you get
out of ring methods will actually be based on the path - otherwise we
exercise the real ring code, but ignore the result and return 1.
"""
# 9 total nodes (6 more past the initial 3) is the cap, no matter if
# this is set higher, or R^2 for R replicas
}}}
All that jazz about part power and doing something trixy in _get_parts should be pulled out.
CVE References
description: | updated |
description: | updated |
Changed in swift: | |
assignee: | nobody → Aniruddha Singh Gautam (aniruddha-gautam) |
Reviewed: https:/ /review. openstack. org/253631 /git.openstack. org/cgit/ openstack/ swift/commit/ ?id=3a0486e532f 22af0d3c8a5c5d7 8613c22e786ff6
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3a0486e532f22af 0d3c8a5c5d78613 c22e786ff6
Author: Sivasathurappan Radhakrishnan <email address hidden>
Date: Fri Dec 4 17:43:00 2015 +0000
Deleted comment about part power in FakeRing
Deleted comment about parameter part power in Class FakeRing as its 491038991cdfd76 86c9d961545.
behavior got dropped in I8bfc388a04eff6
Change-Id: Iec7d2565a77e48 493b0056021066d 8d8eab65d0b
Closes-Bug: #1488704