SSL session object is not deleted for SSL handshake failures

[Prabhjot Singh Sethi]

in case an error occurs (mainly due to protocol/certs) while doing a SSL handshake.

SSL server fails to delete the closed session object, resulting in memory loss.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13403
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13404
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13403
Committed: http://github.org/Juniper/contrail-controller/commit/8e52d701f8786ab9e6c11e5b7bd6cf3312fb21ad
Submitter: Zuul
Branch: master

commit 8e52d701f8786ab9e6c11e5b7bd6cf3312fb21ad
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Aug 28 16:18:14 2015 +0530

Fix session object reference management for SSL

Issue:
------
In case of SSL certificate Authentication failure,
SSL/TCP infra was not releasing the reference to
session keeping the object forever in the map.

this was happening since TCP server state machine moves
ahead by adding the session to reference map before ssl
handshake is triggered, on handshake failure infra
doesn't remove the session from reference map causing
this issue

Fix:
----
move SSL handshake to the context of SSL server instead
of SSL Session object so that the Accept/Connect state
machine complete event can be triggered once the
handshake is complete

Added test case of the same.

Closes-Bug: 1488434
Change-Id: Ia8436f0f31392dae3315f6f025ca3046af485964

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13404
Committed: http://github.org/Juniper/contrail-controller/commit/3b9dc73a31959ca2cffd7357dbafb62e160df4ba
Submitter: Zuul
Branch: R2.20

commit 3b9dc73a31959ca2cffd7357dbafb62e160df4ba
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Aug 28 16:18:14 2015 +0530

Fix session object reference management for SSL

Issue:
------
In case of SSL certificate Authentication failure,
SSL/TCP infra was not releasing the reference to
session keeping the object forever in the map.

this was happening since TCP server state machine moves
ahead by adding the session to reference map before ssl
handshake is triggered, on handshake failure infra
doesn't remove the session from reference map causing
this issue

Fix:
----
move SSL handshake to the context of SSL server instead
of SSL Session object so that the Accept/Connect state
machine complete event can be triggered once the
handshake is complete

Added test case of the same.

Closes-Bug: 1488434
Change-Id: Ia8436f0f31392dae3315f6f025ca3046af485964
(cherry picked from commit 8e52d701f8786ab9e6c11e5b7bd6cf3312fb21ad)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)