heat-manage script fails on encryption due to invalid data

Bug #1488326 reported by Pratik Mallya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Jason Dunsmore

Bug Description

The heat-manage update_params encrypt script is meant to be used as a tool for encrypting parameters in database entries for older stacks. For encrypting the database, the service may be required to be taken offline; thus the script should be as robust as possible. In particular, if the db entry contains malformed data, instead of crashing, the script should log the error and continue processing. This does not happen currently, where malformed data often cause the script to crash.

Changed in heat:
assignee: nobody → Pratik Mallya (pratik-mallya)
status: New → In Progress
Changed in heat:
importance: Undecided → High
milestone: none → liberty-3
Changed in heat:
milestone: liberty-3 → liberty-rc1
tags: added: liberty-rc-potential
Changed in heat:
milestone: liberty-rc1 → next
Changed in heat:
milestone: next → mitaka-1
tags: removed: liberty-rc-potential
Changed in heat:
milestone: mitaka-1 → mitaka-2
Revision history for this message
Sergey Kraynev (skraynev) wrote :

I can not find corresponding patch on review, so move it to Triaged

Changed in heat:
milestone: mitaka-2 → mitaka-3
status: In Progress → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Pratik Mallya (<email address hidden>) on branch: master
Review: https://review.openstack.org/216536

Changed in heat:
milestone: mitaka-3 → mitaka-rc1
Changed in heat:
status: Triaged → In Progress
Changed in heat:
milestone: mitaka-rc1 → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/295520

Changed in heat:
assignee: Pratik Mallya (pratik-mallya) → Jason Dunsmore (jasondunsmore)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/295520
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4307f8722c3961b01105c2deab29e198a13b7a1c
Submitter: Jenkins
Branch: master

commit 4307f8722c3961b01105c2deab29e198a13b7a1c
Author: Jason Dunsmore <email address hidden>
Date: Mon Mar 21 08:53:04 2016 -0600

    Make encryption script log exception and continue

    The heat-manage update_params encrypt script is meant to be used
    as a tool for encrypting parameters in database entries for older
    stacks. For encrypting the database, the service may be required
    to be taken offline; thus the script should be as robust as
    possible. In particular, if the db entry contains malformed data,
    instead of crashing, the script will log the error and continue
    processing of further entries.

    Change-Id: Id9c98ee87adf64f58ba25bb19269a38af71853d5
    Co-Authored-By: Pratik Mallya <email address hidden>
    Closes-Bug: #1488326

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b1

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.