FC with LUN ID >255 not recognized

[Stefan Amann]

(s390 architecture/System z Series only) FC LUNs with LUN ID >255 are not recognized by neither Cinder nor Nova when trying to attach the volume.
The issue is that Fibre-Channel volumes need to be added using the unit_add command with a properly formatted LUN string.
The string is set correctly for LUNs <=0xff. But not for LUN IDs within the range 0xff and 0xffff.
Due to this the volumes do not get properly added to the hypervisor configuration and the hypervisor does not find them.

Note: The change for Liberty os-brick is ready. I would also like to patch it back to Kilo. Since os-brick has been integrated with Liberty, but was separate before, I need to release a patch for Nova, Cinder, and os-brick. Unfortunately there is no option on this page to nominate the patch for Kilo. Can somebody help? Thank you!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/216411

[Jay Bryant (jsbryant)]

For some reason I don't have the option to nominate this for Kilo in Cinder, but we should get this change pulled back there.

[Stefan Amann (stefan-amann)]

The change for Liberty os-brick is ready. I would also like to patch it back to Kilo. Since os-brick has been integrated with Liberty, but was separate before, I need to release a patch for Nova, Cinder, and os-brick. Unfortunately there is no option on this page to nominate the patch for Kilo. Can somebody help? Thank you!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/217016

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/217197

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216411
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=75d1f38e3bfe487df77f7328ca6e86a15043d80b
Submitter: Jenkins
Branch: master

commit 75d1f38e3bfe487df77f7328ca6e86a15043d80b
Author: Stefan Amann <email address hidden>
Date: Mon Aug 24 22:19:18 2015 +0200

    Handle FC LUN IDs greater 255 correctly on s390x architectures

    FC LUN IDs betfeen 100 hex and ffff hex need to be formatted correctly
    for the unit_add command. Otherwise, the volume will not be added to the
    hypervisor configuration and the hypervisor will not be able to perform
    I/O to it.

    Closes-Bug: #1488233

    Change-Id: Iaa0ead59132d6baf8bcb9e3dd95d4839c26e93ea

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/217016
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=24251dfc74bea6ecda718c74ca8e248ab5a6ab9b
Submitter: Jenkins
Branch: stable/kilo

commit 24251dfc74bea6ecda718c74ca8e248ab5a6ab9b
Author: Stefan Amann <email address hidden>
Date: Wed Aug 26 09:55:24 2015 +0200

    Handle FC LUN IDs greater 255 correctly on s390x architectures

    ----
    NOTE(Stefan Amann): Nova uses os-brick since commit
    e6cdd1693ba843e1c8dcccbde3af20f62eb0b5a2. That's the reason why I cannot
    backport a valid nova patch from master.

    os-brick contains this change with commit
    75d1f38e3bfe487df77f7328ca6e86a15043d80b.
    ----

    FC LUN IDs between hex 100 and hex ffff need to be formatted correctly
    for the unit_add command. Otherwise, the volume will not be added to the
    hypervisor configuration and the hypervisor will not be able to perform
    I/O to it.

    Closes-Bug: #1488233

    Change-Id: I6a023daadc1880c8770fab3ae82dd2b677ca0e4f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/217197
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=47351ade8eaa76b5aa644cf526080704b1da8b37
Submitter: Jenkins
Branch: stable/kilo

commit 47351ade8eaa76b5aa644cf526080704b1da8b37
Author: Stefan Amann <email address hidden>
Date: Wed Aug 26 15:58:23 2015 +0200

    Handle FC LUN IDs greater 255 correctly on s390x architectures

    ----
    NOTE(Stefan Amann): as of Liberty Cinder uses os-brick. That's the
    reason why I cannot backport a valid Cinder patch from master.

    os-brick contains this change with commit
    75d1f38e3bfe487df77f7328ca6e86a15043d80b.
    ----

    FC LUN IDs between hex 100 and hex ffff need to be formatted correctly
    for the unit_add command. Otherwise, the volume will not be added to the
    hypervisor configuration and the hypervisor will not be able to perform
    I/O to it.

    Closes-Bug: #1488233

    Change-Id: I3910b5d7e0ae97e6b7f02c4b1c2be8ff8edd8dc7

[Sean McGinnis (sean-mcginnis)]

Post-Kilo Cinder uses os-brick. Since this fix went in to os-brick and was released with version 0.4.0, Cinder now should work as of the requirements update to that library version in commit e50576c2d495e6828f335029e713655c27a6fc5b.

[Sean Dague (sdague)]

It looks like all the patches to nova have landed