Ceilometer

Event requeue/ack will not work when workload_partitioning is enabled

Bug #1488202 reported by Rohit Jaiswal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Rohit Jaiswal
Ceilometer 5.0.0 "liberty"
Kilo
Fix Released
Undecided
Rohit Jaiswal
Ceilometer 2015.1.3

Bug Description

When workload_partitioning is enabled, additional queues are established per agent to distribute sample processing and publishing, the publishing of samples occurs at: https://github.com/openstack/ceilometer/blob/master/ceilometer/pipeline.py#L121.

In the non-HA mode, the publishing occurs at https://github.com/openstack/ceilometer/blob/master/ceilometer/event/endpoint.py#L77, which is setup to handle exception from the event conversion or publishing (when single publisher is configured) and requeue or ack accordingly.

Similar exception handling needs to occur in HA mode in pipeline:EventPipelineEndpoint: https://github.com/openstack/ceilometer/blob/master/ceilometer/pipeline.py#L121

Rohit Jaiswal (rohit-jaiswal-3)
Changed in ceilometer:
assignee: nobody → Rohit Jaiswal (rohit-jaiswal-3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217980

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/217980
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=967d9272780f379c90a0a77330422c4b80440617
Submitter: Jenkins
Branch: master

commit 967d9272780f379c90a0a77330422c4b80440617
Author: Rohit Jaiswal <email address hidden>
Date: Fri Aug 28 00:15:38 2015 +0000

    Requeuing event with workload_partitioning on publish failure

    when workload_partitioning is enabled,
    publishing of samples occurs in the
    pipeline listeners. If publishing fails
    when single publisher is configured, event
    will not be requeued or ack'ed.

    This fix requeues or acks the event based on
    ack_on_event_error.

    Change-Id: I8f2f889736c8897e5b15952ab32308cf33205c3f
    Closes-Bug: 1488202

Changed in ceilometer:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/227616

Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/kilo)

Reviewed: https://review.openstack.org/227616
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=74841ad971c4c4914961b8123fef47d8fde593f0
Submitter: Jenkins
Branch: stable/kilo

commit 74841ad971c4c4914961b8123fef47d8fde593f0
Author: Rohit Jaiswal <email address hidden>
Date: Fri Aug 28 00:15:38 2015 +0000

    Requeuing event with workload_partitioning on publish failure

    when workload_partitioning is enabled,
    publishing of samples occurs in the
    pipeline listeners. If publishing fails
    when single publisher is configured, event
    will not be requeued or ack'ed.

    This fix requeues or acks the event based on
    ack_on_event_error.

    Change-Id: I8f2f889736c8897e5b15952ab32308cf33205c3f
    Closes-Bug: 1488202
    (cherry picked from commit 967d9272780f379c90a0a77330422c4b80440617)

Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.