OpenStack Dashboard (Horizon)

missing mock in loadbalancer tests

Bug #1488168 reported by David Lyle on 2015-08-24

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	David Lyle	OpenStack Dashboard (Horizon) 8.0.0 "liberty"

Bug Description

Recent merge introduced unmocked API calls for loadbalancer tests:

Error while checking action permissions.
Traceback (most recent call last):
  File "/home/david-lyle/horizon/horizon/tables/base.py", line 1266, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/david-lyle/horizon/horizon/tables/actions.py", line 136, in _allowed
    return self.allowed(request, datum)
  File "/home/david-lyle/horizon/openstack_dashboard/dashboards/project/loadbalancers/tables.py", line 312, in allowed
    if not api.network.floating_ip_supported(request):
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 91, in floating_ip_supported
    return NetworkClient(request).floating_ips.is_supported()
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 37, in __init__
    neutron.is_extension_supported(request, 'security-group')):
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1161, in is_extension_supported
    extensions = list_extensions(request)
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1152, in list_extensions
    extensions_list = neutronclient(request).list_extensions()
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 102, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 522, in list_extensions
    return self.get(self.extensions_path, params=_params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 293, in get
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 270, in retry_request
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 200, in do_request
    content_type=self.content_type())
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 170, in do_request
    **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 106, in _cs_request
    raise exceptions.ConnectionFailed(reason=e)
ConnectionFailed: Connection to neutron failed: ('Connection aborted.', gaierror(-2, 'Name or service not known'))
Error while checking action permissions.
Traceback (most recent call last):
  File "/home/david-lyle/horizon/horizon/tables/base.py", line 1266, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/david-lyle/horizon/horizon/tables/actions.py", line 136, in _allowed
    return self.allowed(request, datum)
  File "/home/david-lyle/horizon/openstack_dashboard/dashboards/project/loadbalancers/tables.py", line 348, in allowed
    if not api.network.floating_ip_supported(request):
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 91, in floating_ip_supported
    return NetworkClient(request).floating_ips.is_supported()
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 37, in __init__
    neutron.is_extension_supported(request, 'security-group')):
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1161, in is_extension_supported
    extensions = list_extensions(request)
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1152, in list_extensions
    extensions_list = neutronclient(request).list_extensions()
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 102, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 522, in list_extensions
    return self.get(self.extensions_path, params=_params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 293, in get
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 270, in retry_request
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 200, in do_request
    content_type=self.content_type())
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 170, in do_request
    **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 106, in _cs_request
    raise exceptions.ConnectionFailed(reason=e)
ConnectionFailed: Connection to neutron failed: ('Connection aborted.', gaierror(-2, 'Name or service not known'))
Error while checking action permissions.
Traceback (most recent call last):
  File "/home/david-lyle/horizon/horizon/tables/base.py", line 1266, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/david-lyle/horizon/horizon/tables/actions.py", line 136, in _allowed
    return self.allowed(request, datum)
  File "/home/david-lyle/horizon/openstack_dashboard/dashboards/project/loadbalancers/tables.py", line 312, in allowed
    if not api.network.floating_ip_supported(request):
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 91, in floating_ip_supported
    return NetworkClient(request).floating_ips.is_supported()
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 37, in __init__
    neutron.is_extension_supported(request, 'security-group')):
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1161, in is_extension_supported
    extensions = list_extensions(request)
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1152, in list_extensions
    extensions_list = neutronclient(request).list_extensions()
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 102, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 522, in list_extensions
    return self.get(self.extensions_path, params=_params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 293, in get
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 270, in retry_request
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 200, in do_request
    content_type=self.content_type())
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 170, in do_request
    **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 106, in _cs_request
    raise exceptions.ConnectionFailed(reason=e)
ConnectionFailed: Connection to neutron failed: ('Connection aborted.', gaierror(-2, 'Name or service not known'))
Error while checking action permissions.
Traceback (most recent call last):
  File "/home/david-lyle/horizon/horizon/tables/base.py", line 1266, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/david-lyle/horizon/horizon/tables/actions.py", line 136, in _allowed
    return self.allowed(request, datum)
  File "/home/david-lyle/horizon/openstack_dashboard/dashboards/project/loadbalancers/tables.py", line 348, in allowed
    if not api.network.floating_ip_supported(request):
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 91, in floating_ip_supported
    return NetworkClient(request).floating_ips.is_supported()
  File "/home/david-lyle/horizon/openstack_dashboard/api/network.py", line 37, in __init__
    neutron.is_extension_supported(request, 'security-group')):
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1161, in is_extension_supported
    extensions = list_extensions(request)
  File "/home/david-lyle/horizon/horizon/utils/memoized.py", line 90, in wrapped
    value = cache[key] = func(*args, **kwargs)
  File "/home/david-lyle/horizon/openstack_dashboard/api/neutron.py", line 1152, in list_extensions
    extensions_list = neutronclient(request).list_extensions()
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 102, in with_params
    ret = self.function(instance, *args, **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 522, in list_extensions
    return self.get(self.extensions_path, params=_params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 293, in get
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 270, in retry_request
    headers=headers, params=params)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/v2_0/client.py", line 200, in do_request
    content_type=self.content_type())
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 170, in do_request
    **kwargs)
  File "/home/david-lyle/horizon/.venv/local/lib/python2.7/site-packages/neutronclient/client.py", line 106, in _cs_request
    raise exceptions.ConnectionFailed(reason=e)
ConnectionFailed: Connection to neutron failed: ('Connection aborted.', gaierror(-2, 'Name or service not known'))

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-08-24: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/216346

Changed in horizon:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-09-02: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/216346
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e9f819d7de8eff686faa0abb8651b46a78f891cd
Submitter: Jenkins
Branch: master

commit e9f819d7de8eff686faa0abb8651b46a78f891cd
Author: David Lyle <email address hidden>
Date: Mon Aug 24 11:28:53 2015 -0600

Adding missing mocks to lbaas tests

    test_delete_vip is missing mocks, so it's hitting the API and timing
    out and dumping to the console. Adding mocks and removing noise from
    console log.

Closes-Bug: #1488168
Change-Id: Ib428e43d34db270ca3ad635b2c9b724dbc75df7b

Changed in horizon:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2015-09-03

Changed in horizon:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-10-15

Changed in horizon:
milestone:	liberty-3 → 8.0.0

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #1488571

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.