The new fwts_test script will break the firmware/fwts_$1.log attachment job

[Po-Hsu Lin]

We have a pair of fwts tests in our job definition file, the "firmware/fwts_$1", which will be generated by the "firmware/fwts" local job, and its attachment job "firmware/fwts_$1.log", which will be generated by the "firmware/fwts_logs" local job
These two jobs will be generated base on the fwts_test --list output.

However, with the recent change in fwts, the following test cases will have a trailing "_hwe" in the filename
HWE_TESTS = ['mtrr',
             'virt',
             'apicedge',
             'klog',
             'oops',
             'uefibootpath']

This filename change will cause the attachment jobs fail.

Affected test plans (with both firmware/fwts and firmware/fwts_logs in the test plan):
certification-client:
client-cert-14-04.pxu
client-cert-14-04-3.pxu
client-cert.whitelist
client-selftest.whitelist
client-selftest-14-04.whitelist

CDTS:
ihv-firmware.pxu
ihv-firmware-advanced.pxu

(certification-server provider was not affected)

But luckily,
it seems that only the CDTS provider do have the separated test cases for fwts, therefore this bug do have some impact on it.
For the test plans in certification-client provider, they just run the local job, so I think we can safely remove them.

[Po-Hsu Lin (cypressyew)]

BTW, I think we should rename this kind of local jobs, maybe rename them with a "generator-" prefix, so that it will become easier to read in the test plan, also, we could run all the local jobs by just running "generator-.* job".

[Po-Hsu Lin (cypressyew)]

Please refer to https://code.launchpad.net/~cypressyew/plainbox-provider-canonical-certification/+git/plainbox-provider-canonical-certification/+merge/268870 for the MR of certification-client provider.

[Po-Hsu Lin (cypressyew)]

With the fix landed on checkbox, CDTS still affected by this issue,
as those tests in ihv-firmware.pxu will run the test with "-t" for fwts, therefore "_hwe" will exist in the file name.
e.g. firmware/fwts_oops test will run:
fwts_test -t oops -l $PLAINBOX_SESSION_SHARE/fwts_oops.log

[Sylvain Pineau (sylvain-pineau)]

CDTS is a bit special as the official release are offline tarballs. But the tests using -t won't generate the hwe logs so even the local job creating the jobs for cdts with -t will benefit from the fix.

[Po-Hsu Lin (cypressyew)]

Ahh, ok, it's "without -t", I misread this section, thanks!
We're good now.