Parameter osapi_max_limit is always used by default even it's set in the configuration file

[Yuriy Nesenenko]

Parameter osapi_max_limit is always used by default even it's set in the configuration file. This happens because this parameter is passed to the function declaration in such functions common.get_pagination_params(params, max_limit=CONF.osapi_max_limit), common._get_limit_param(params, max_limit=CONF.osapi_max_limit),common. limited(items, request, max_limit=CONF.osapi_max_limit), common.limited_by_marker(items, request, max_limit=CONF.osapi_max_limit) etc

[Anton Arefiev (aarefiev)]

The problem is default value max_limit is initialized before value from config is read. Default parameter values are always evaluated when, and only when, the “def” statement they belong to is executed. So default value is used all time.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216661
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e894b3dd9285a1fb711aee63eb96be1cfe44375b
Submitter: Jenkins
Branch: master

commit e894b3dd9285a1fb711aee63eb96be1cfe44375b
Author: Yuriy Nesenenko <email address hidden>
Date: Tue Aug 25 13:55:56 2015 +0300

    Parameter osapi_max_limit is always used by default

    Default value max_limit is initialized before a value is read from
    the config file. Default parameter values are always evaluated when
    the “def” statement they belong to is executed. So parameter
    osapi_max_limit is always used by default even it's set in the
    configuration file.

    Change-Id: I1414667d30e98b56c5eb1b09b802bab823b37e2d
    Closes-Bug: #1487510