Can not update resources which are in UPDATE_IN_PROGRESS anymore

Bug #1487288 reported by huangtianhua
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua
Kilo
Fix Released
High
Zane Bitter
Liberty
Fix Released
Medium
huangtianhua

Bug Description

1. create a stack with a nova server
2. update the stack to rebuild the server
3. something happened, the engine service down when stack updating
4. after the engine service up again, the stack go to UPDATE_FAILED
5. try update the stack again, but can't to update, the reason is: Resource update already requested

The code https://github.com/openstack/heat/blob/master/heat/engine/resource.py#L934
Heat will check the resource whether is in progress, but didn't consider the engine down situation.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/215486

Changed in heat:
status: New → In Progress
Changed in heat:
importance: Undecided → Medium
Changed in heat:
milestone: none → liberty-3
Changed in heat:
milestone: liberty-3 → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/215486
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=fae9ae327fbd9f1bfb1d6301a49b780e7a9192cd
Submitter: Jenkins
Branch: master

commit fae9ae327fbd9f1bfb1d6301a49b780e7a9192cd
Author: huangtianhua <email address hidden>
Date: Fri Aug 21 14:17:50 2015 +0800

    Set resource status to FAILED when engine is down

    When resource is in status IN_PROGRESS and engine service
    went down, user can't operate(such as update) the resource
    anymore even if the engine service is back again.
    This patch set the resources to FAILED status when
    the engine starting.

    Change-Id: Ib49895d45d727e117af5dbdcf84d58b196991274
    Closes-Bug: #1487288

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Zane Bitter (zaneb)
tags: added: kilo-backport-potential
Revision history for this message
Zane Bitter (zaneb) wrote :

This is particularly bad in kilo because of bug 1446252.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/231802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/231802
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2f14f1fcd592e8b9cd77903e02daf5c34e952dba
Submitter: Jenkins
Branch: stable/kilo

commit 2f14f1fcd592e8b9cd77903e02daf5c34e952dba
Author: huangtianhua <email address hidden>
Date: Fri Aug 21 14:17:50 2015 +0800

    Set resource status to FAILED when engine is down

    When resource is in status IN_PROGRESS and engine service
    went down, user can't operate(such as update) the resource
    anymore even if the engine service is back again.
    This patch set the resources to FAILED status when
    the engine starting.

    Change-Id: Ib49895d45d727e117af5dbdcf84d58b196991274
    Closes-Bug: #1487288
    (cherry picked from commit fae9ae327fbd9f1bfb1d6301a49b780e7a9192cd)

Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.