Support specifying memory on container-create

Bug #1487224 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
High
hongbin

Bug Description

Docker support an option to specify memory limit:

$ docker create --help

Usage: docker create [OPTIONS] IMAGE [COMMAND] [ARG...]

Create a new container

  ...
  -m, --memory="" Memory limit (format: <number><optional unit>, where unit = b, k, m or g)
  ...

Magnum needs this option on "magnum container-create". This will help for the capability planning and autoscaling.

hongbin (hongbin034)
tags: added: low-hanging-fruit
Changed in magnum:
assignee: nobody → Vilobh Meshram (vilobhmm)
Changed in magnum:
status: New → Confirmed
Revision history for this message
hongbin (hongbin034) wrote :

@Vilobh, do you have cycle to revisit this bug? We need it for the autoscaling feature.

Changed in magnum:
importance: Undecided → High
hongbin (hongbin034)
Changed in magnum:
assignee: Vilobh Meshram (vilobhmm) → hongbin (hongbin034)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/229645

Changed in magnum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/229645
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=454911f8308f672b5c4499fd4958a157929dc78d
Submitter: Jenkins
Branch: master

commit 454911f8308f672b5c4499fd4958a157929dc78d
Author: Hongbin Lu <email address hidden>
Date: Wed Sep 30 17:33:48 2015 -0400

    Allow container memory size to be specified

    With docker, users have an option to specify memory size when
    creating containers. This patch bring this capability to Magnum.
    Specifying memory size is optional but recommended. If memory size
    is unset, magnum will set mem_limit as None on docker create.

    Change-Id: Ife88284402ff39a7b2e051f6e66913e502f2ba8c
    Closes-Bug: #1487224

Changed in magnum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on magnum (master)

Change abandoned by Hongbin Lu (<email address hidden>) on branch: master
Review: https://review.openstack.org/232175
Reason: According to the feedback from team members, quickstart guide is not a good place to document the memory option. Abandon this patch.

Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-2
status: Fix Committed → Fix Released
Adrian Otto (aotto)
Changed in magnum:
milestone: mitaka-2 → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.