Cinder

NetApp NFS driver can miss valid glance image locations

Bug #1487074 reported by Tom Barron
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Tom Barron
Cinder 7.0.0 "liberty"
Kilo
Fix Released
Undecided
Unassigned
Cinder 2015.1.2

Bug Description

At https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/dataontap/nfs_base.py#L681, if there is a list of locations and e.g. the first location is not an NFS location, the code breaks out of the loop and does not look at other locations. We should instead continue to loop to see if there are other NFS locations.

Tom Barron (tpb)
Changed in grenade:
assignee: nobody → Tom Barron (tpb)
Tom Barron (tpb)
affects: grenade → cinder
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221972

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/221972
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bb4321c61d40174b7314315568068a213697c370
Submitter: Jenkins
Branch: master

commit bb4321c61d40174b7314315568068a213697c370
Author: Tom Barron <email address hidden>
Date: Mon Aug 24 13:21:48 2015 -0400

    Fix NetApp loop in clone of NFS backed images

    If there is a list of locations for glance images and an unsuitable
    location is encountered when iterating through the list, current code
    breaks out of the loop, failing to find later, valid locations.

    Here we fix this issue by ignoring invalid locations and continuing
    through the loop rather than breaking out when we find invalid locations.

    Closes-bug: 1487074

    Change-Id: Id2435ba633629367fa1bd8f339fc283f47eeb012

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/222253

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/kilo)

Reviewed: https://review.openstack.org/222253
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=813cf650c6e25bc59695c5a13fcaa46f76175346
Submitter: Jenkins
Branch: stable/kilo

commit 813cf650c6e25bc59695c5a13fcaa46f76175346
Author: Tom Barron <email address hidden>
Date: Mon Aug 24 13:21:48 2015 -0400

    Fix NetApp loop in clone of NFS backed images

    If there is a list of locations for glance images and an unsuitable
    location is encountered when iterating through the list, current code
    breaks out of the loop, failing to find later, valid locations.

    Here we fix this issue by ignoring invalid locations and continuing
    through the loop rather than breaking out when we find invalid locations.

    Closes-bug: 1487074

    Change-Id: Id2435ba633629367fa1bd8f339fc283f47eeb012
    (cherry picked from commit bb4321c61d40174b7314315568068a213697c370)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.