v2 API allows CNAME RRSets with multiple Records

Bug #1486743 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Tim Simmons
Kilo
Fix Committed
High
Graham Hayes

Bug Description

    ➜ ~ http http://127.0.0.1:9001/v2/zones/377ef1e0-0901-4a2e-9167-94d51c1febeb/recordsets name=www.example.com. type=CNAME records:='["ww1.exmaple.com.", "ww2.example.com."]' -v
    POST /v2/zones/377ef1e0-0901-4a2e-9167-94d51c1febeb/recordsets HTTP/1.1
    Accept: application/json
    Accept-Encoding: gzip, deflate
    Connection: keep-alive
    Content-Length: 98
    Content-Type: application/json
    Host: 127.0.0.1:9001
    User-Agent: HTTPie/0.9.2

    {
        "name": "www.example.com.",
        "records": [
            "ww1.exmaple.com.",
            "ww2.example.com."
        ],
        "type": "CNAME"
    }

    HTTP/1.1 202 Accepted
    Connection: keep-alive
    Content-Length: 486
    Content-Type: application/json; charset=UTF-8
    Date: Wed, 19 Aug 2015 20:58:41 GMT
    Location: http://127.0.0.1:9001/v2/zones/377ef1e0-0901-4a2e-9167-94d51c1febeb/recordsets/b4c82a14-7c33-471a-ae0f-d0cf976a5a75
    X-Openstack-Request-Id: req-036f0db6-9822-4646-959f-120c2e8cc0e4

    {
        "action": "CREATE",
        "created_at": "2015-08-19T20:58:40.947732",
        "description": null,
        "id": "b4c82a14-7c33-471a-ae0f-d0cf976a5a75",
        "links": {
            "self": "http://127.0.0.1:9001/v2/zones/377ef1e0-0901-4a2e-9167-94d51c1febeb/recordsets/b4c82a14-7c33-471a-ae0f-d0cf976a5a75"
        },
        "name": "www.example.com.",
        "records": [
            "ww1.exmaple.com.",
            "ww2.example.com."
        ],
        "status": "PENDING",
        "ttl": null,
        "type": "CNAME",
        "updated_at": null,
        "version": 1,
        "zone_id": "377ef1e0-0901-4a2e-9167-94d51c1febeb"
    }

Tim Simmons (timsim)
Changed in designate:
importance: Undecided → Critical
status: New → Triaged
milestone: none → liberty-3
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-3 → liberty-rc1
Tim Simmons (timsim)
Changed in designate:
assignee: nobody → Tim Simmons (tim-simmons-t)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/224906

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/224906
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=476980e9a1a7c63366faca5762ca6e1ca8581c24
Submitter: Jenkins
Branch: master

commit 476980e9a1a7c63366faca5762ca6e1ca8581c24
Author: TimSimmons <email address hidden>
Date: Thu Sep 17 16:28:58 2015 -0500

    Ensure CNAME RRSets only have one record

    Throw a 400 error back at the user if they try to create a CNAME
    RRSet with more than 1 record.

    Change-Id: I252fcd046dc902ff28162d831c0c0fd6b0dea3d2
    Closes-Bug: 1486743

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/228589

Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-rc1 → 1.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (stable/kilo)

Reviewed: https://review.openstack.org/228589
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=f058e1b582825cf6af7923b1d87b9f35e1de2dc6
Submitter: Jenkins
Branch: stable/kilo

commit f058e1b582825cf6af7923b1d87b9f35e1de2dc6
Author: TimSimmons <email address hidden>
Date: Thu Sep 17 16:28:58 2015 -0500

    Ensure CNAME RRSets only have one record

    Throw a 400 error back at the user if they try to create a CNAME
    RRSet with more than 1 record.

    Closes-Bug: 1486743
    Change-Id: I252fcd046dc902ff28162d831c0c0fd6b0dea3d2

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.