python-cinderclient

test_password_prompted makes un-mocked DNS lookup requests

Bug #1486647 reported by Derrick Wippler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Low
Derrick Wippler
python-cinderclient 1.4.0 "1.4.0"

Bug Description

If unit tests are run on a network with DNS intercepts test_password_prompted will fail as the test will raise 'keystoneclient.exceptions.DiscoveryFailure' instead of the expected 'ks_exc.ConnectionRefused'. The test should mock out the request so no DNS lookups are preformed on the network during the test.

Tags: tests
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214704

Changed in python-cinderclient:
assignee: nobody → Derrick Wippler (thrawn01)
status: New → In Progress
Eric Harney (eharney)
tags: added: tests
Changed in python-cinderclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/214704
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=50758ba475e7a8d7783d511b9b161899c41641b5
Submitter: Jenkins
Branch: master

commit 50758ba475e7a8d7783d511b9b161899c41641b5
Author: Derrick J. Wippler <email address hidden>
Date: Wed Aug 19 11:36:33 2015 -0500

    Fixed test_password_prompted

    test_password_prompted no longer makes DNS lookups on the network.

    Change-Id: If310f52e829b09b01c76d02deae4aec74f00870d
    Closes-Bug: 1486647

Changed in python-cinderclient:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in python-cinderclient:
milestone: none → 1.4.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 1.4.0

This issue was fixed in the openstack/python-cinderclient 1.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.