Copies in concerto data should have prices

[Kathy Lussier]

Copies in the concerto data do not have any prices set. The absence of price data makes it difficult to test any code or workflows related to setting transactions to lost or long overdue.

[Michele Morgan (mmorgan)]

Including prices in concerto copy records would certainly facilitate testing billing functionality, for both developers and new Evergreen users.

[Chris Sharp (chrissharp123)]

I have a branch to test at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1486592_add_prices_to_concerto_data

It works for me!

[Ben Shum (bshum)]

Targeting this towards 2.next for now (so that it's not lost in the wild) till we're sure this is meant for 2.10 review and inclusion.

[Ben Shum (bshum)]

Works for the most part, however I uncovered about five copies that were created in the sample data that did not get a price included with them. I tracked those back to some individual entries in assets_concerto.sql.

Pushed a new working branch with my signoff for csharp's work along with an additional commit that includes changes to add random price for those additional copies.

Branch: user/bshum/add-price-to-concerto-data

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/add-price-to-concerto-data

[Thomas Berezansky (tsbere)]

To better emulate real-world data shouldn't we leave a few copies without prices?

[Galen Charlton (gmc)]

I've pushed Chris' patch as signed off by Ben to master -- thanks, Chris! I agree with Thomas that it makes sense to leave at least a few copies without prices, so I've not pushed Ben's follow-up.

Since a one-liner suffices to describe this for the sake of the release notes, I've tagged this with "rm-to-write-notes" as a reminder to myself to include this in a miscellaneous/minor section of the release notes when I cut 2.10.