Rackspace Cloud LoadBalancer uses scheduler tasks

Bug #1486463 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Jason Dunsmore

Bug Description

This is a spin-off to https://bugs.launchpad.net/heat/+bug/1393268.

In the convergence phase 2 there will be couple of changes affecting Heat resources:
- workers will be processing a single resource in a blocking fashion, so resources should not use the scheduler logic in handle_* / check_*_complete
- handle_* and check_*_complete might be processed on different workers, so arguments passed between them must be easily serializable (that means no scheduler tasks, no actual rich objects returned from API clients, only something that can be easily converted to/from json/msgpack/other messaging payload format)

Things that need fixing the Rackspace Cloud LoadBalancer resource:
- handle_create uses a scheduler.TaskRunner object and returns a (rich?) loadbalancer object
- handle_delete returns scheduler.TaskRunner object
- handle_update returns a (possibly quite long) list of scheduler.TaskRunner objects

for reference see these changes in heat in-tree resources
https://review.openstack.org/#/q/project:openstack/heat+branch:master+topic:%255E.*1393268,n,z

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/216437

Changed in heat:
assignee: Randall Burt (randall-burt) → Jason Dunsmore (jasondunsmore)
status: New → In Progress
Changed in heat:
milestone: none → liberty-3
Changed in heat:
milestone: liberty-3 → liberty-rc1
Changed in heat:
milestone: liberty-rc1 → ongoing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/216437
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ee0348e40e5730a1600d229d000d661835370f7a
Submitter: Jenkins
Branch: master

commit ee0348e40e5730a1600d229d000d661835370f7a
Author: Jason Dunsmore <email address hidden>
Date: Fri Sep 25 16:55:18 2015 -0500

    Do not pass rich objects in Cloud LoadBalancer delete

    Remove passing of rich objects in the Rackspace::Cloud::LoadBalancer
    resource during delete to make the resource compatible with the
    convergence Heat engine.

    Change-Id: Id50ae2f206d9d9106618ba25af230d0c3528efbd
    Partial-Bug: #1486463

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/231072

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/231178

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/231072
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=895eef244dd148caf07119f6da91da6b31e19ad3
Submitter: Jenkins
Branch: master

commit 895eef244dd148caf07119f6da91da6b31e19ad3
Author: Jason Dunsmore <email address hidden>
Date: Mon Sep 28 16:44:42 2015 -0500

    Do not pass rich objects in Cloud LoadBalancer update

    Remove passing of rich objects in the Rackspace::Cloud::LoadBalancer
    resource during update to make the resource compatible with the
    convergence Heat engine.

    Change-Id: I14a7af419b081e7126e75e8332cb1fd7dace5dd9
    Partial-Bug: #1486463

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/231178
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b83b2a15bfaf9d4f684a12d2209c17025a585ed2
Submitter: Jenkins
Branch: master

commit b83b2a15bfaf9d4f684a12d2209c17025a585ed2
Author: Jason Dunsmore <email address hidden>
Date: Mon Oct 5 15:50:19 2015 -0500

    Do not pass rich objects in Cloud LoadBalancer create

    Remove passing of rich objects in the Rackspace::Cloud::LoadBalancer
    resource during create to make the resource compatible with the
    convergence Heat engine.

    Change-Id: Iac3e41d06d31c1aaea5f066a91aae611d3e851af
    Closes-Bug: #1486463

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b1

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

Changed in heat:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.