Conjoined items - long titles break display of record details page

Bug #1486451 reported by Eva Cerninakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.11
Fix Released
Medium
Unassigned

Bug Description

When a conjoined item with a slightly longer title is added a to a record, then the layout of the record details page is broken (the occurrence or extent of the problem depends on browser font size)
see
http://spok.jabok.cuni.cz/eg/opac/record/16705
or
http://knihovna.jabok.cz/Evergreen/snapshots/conjoined_item.png

(Tested in Evergreen 2.8)

Revision history for this message
Eva Cerninakova (ece) wrote :

The bug is stil relevang in 2.12 (version 0master.53150bb)

description: updated
Revision history for this message
Eva Cerninakova (ece) wrote :

I supposed it has something to do with the span class "bib_peer_title" - however, i have not been able to locate the definition of such class in the style sheet.

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Kathy Lussier (klussier) wrote :

I've seen this happen in the Concerto test dataset too. Records 24 and 93 are sample records.

I looked at the page with Firebug and didn't see any style information associated with bib_peer_title. However, if I changed the #rdetails_status td style from nowrap to wrap, it fixes the problem.

I'm not sure if it's safe to change that style across the board for all those table cells with the rdetails_status id, but maybe it would be okay? I think we would always prefer wrapping in the case of long text over pushing contents off the screen.

Otherwise, there may be a way we can wrap this one particular element.

I wonder if this also happens with really long public notes.

Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Dan Scott for reminding me of this bug. I have a working branch available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1486451-allow-wrapping-for-rdetail-table that removes the no-wrap style.

It also causes wrapping in other columns, such as the shelving location and status columns, but I don't think that's a bad thing since it adds some good flexibility to this table.

Test plan:

Load bib record 15 in the Concerto dataset. Before the patch is loaded, you'll
see that some of the content in the copy details table is pushed off the
screen and requires horizontal scrolling. Post-patch, all of the copy
details will display on screen without horizontal scrolling. In addition
to the change in the Conjoined Items, you also might see some text wrapping
in the Shelving Location and Status columns.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0-alpha
importance: Undecided → Medium
Revision history for this message
Terran McCanna (tmccanna) wrote :

I'll test this during bug squashing week.

Dan Scott (denials)
summary: - Conjoined items - wrong display of record details page
+ Conjoined items - long titles break display of record details page
Revision history for this message
Terran McCanna (tmccanna) wrote :

Looks good, Kathy!

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_12, and rel_2_11. Thanks, Kathy and Terran!

Changed in evergreen:
milestone: 3.0-alpha → 2.12.4
status: Confirmed → Fix Committed
no longer affects: evergreen/2.12
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.