integration tests do not assert that cleanup delete succeeds

Bug #1486303 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steve Baker

Bug Description

Currently integration and functional tests delete stacks on cleanup, but do not wait for delete success before finishing the test.

This leads to tests passing when the stack is left behind in a DELETE_FAILED state.

Changed in heat:
assignee: nobody → Steve Baker (steve-stevebaker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214410

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/214410
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3dbfb0fd92f35949dae1d0f703ffcc2e2d09b7bb
Submitter: Jenkins
Branch: master

commit 3dbfb0fd92f35949dae1d0f703ffcc2e2d09b7bb
Author: Steve Baker <email address hidden>
Date: Wed Aug 19 13:37:08 2015 +1200

    Assert DELETE_COMPLETE on all stack delete cleanup

    Currently stacks are deleted on integration test cleanup but no
    polling is done for DELETE_COMPLETE, so the test will pass even though
    the stack may be in a DELETE_FAILED state.

    This change uses _stack_delete for all cleanup stack deleting, which
    polls for complete.

    Change-Id: Ic44b27130596cf3fa8616608a091b683ea131e0b
    Closes-Bug: #1486303

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.