empty output validation bug

[Kevin Fox]

We recently upgraded to Kilo and some of our existing templates brake due to too strict validation.

https://raw.githubusercontent.com/EMSL-MSC/heat-templates/7254e6936faa8fbc562a6a7239e3927ddc0db22e/cfn/lib/private/FloatingIp_None.yaml
   ^------- is a simple example that use to work but no longer does.

The value of the output was specifically intended to be "" to return to the parent template. In horizon, it returns:
Error: ERROR: Output validation error: Each Output must contain a Value key. It should return the blank string instead.

[Steve Baker (steve-stevebaker)]

Confirmed with heat master and the following launch line

heat stack-create -f FloatingIp_None.yaml -PNetworkId=a -PInstanceId=a -PIpAddress=a -PFloatingIpId=a -PPortId=a a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214396

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214396
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=213bb164501cd2a3b1811f5466b3f613335b2c7c
Submitter: Jenkins
Branch: master

commit 213bb164501cd2a3b1811f5466b3f613335b2c7c
Author: Steve Baker <email address hidden>
Date: Wed Aug 19 12:19:59 2015 +1200

    Allow empty/None output values

    Currently validation fails if a template output Value is set to
    something which evaluates to False. This change makes the check
    look for the Value key instead.

    This fixes what appears to be a behaviour regression from Juno->Kilo.

    Change-Id: I0f5ae779aa46b243c66228e06fa652fb67ea06bf
    Closes-Bug: #1486182

[Kevin Fox (kevpn)]

The patch didn't apply cleanly but with a slight formatting tweak it did on kilo.

Thanks for the fix.
Kevin

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/225518

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/225518
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=22a404d25bb0fe8de4e0e3ee7234d5ccd2066167
Submitter: Jenkins
Branch: stable/kilo

commit 22a404d25bb0fe8de4e0e3ee7234d5ccd2066167
Author: Angus Salkeld <email address hidden>
Date: Mon Sep 21 10:04:44 2015 +1000

    Allow empty/None output values

    Currently validation fails if a template output Value is set to
    something which evaluates to False. This change makes the check
    look for the Value key instead.

    This fixes what appears to be a behaviour regression from Juno->Kilo.

    Conflicts:
     heat/engine/stack.py
     heat/tests/test_stack.py

    Change-Id: I0f5ae779aa46b243c66228e06fa652fb67ea06bf
    Closes-Bug: #1486182
    (cherry picked from commit 213bb164501cd2a3b1811f5466b3f613335b2c7c)