OpenStack Dashboard (Horizon)

Angular tables should use hz-page-header directive

Bug #1485778 reported by Cindy Lu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Paulo Ewerton
OpenStack Dashboard (Horizon) mitaka-1 "m1"

Bug Description

We should use this new directive: https://review.openstack.org/#/c/201661/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/213879

Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/223793

Changed in horizon:
assignee: Cindy Lu (clu-m) → Paulo Ewerton (pauloewerton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Cindy Lu (<email address hidden>) on branch: master
Review: https://review.openstack.org/213879
Reason: Fixed by Paulo's patch: https://review.openstack.org/#/c/223793/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/223793
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c55f0df912c7961ceafde9d8b3c873ff248ac77f
Submitter: Jenkins
Branch: master

commit c55f0df912c7961ceafde9d8b3c873ff248ac77f
Author: Paulo Ewerton <email address hidden>
Date: Tue Sep 15 20:00:34 2015 +0000

    hz-page-header should allow string interpolations

    As noted by Thai in his review for the patch
    https://review.openstack.org/#/c/213879/, the hz-page-header
    directive should be updated to allow string interpolations
    such as {$ ... $} in order to support angular translate.

    This patch can be tested by setting DISABLED = False in
    _1051_project_ng_images_panel.py and _3031_identity_users_panel.py
    and checking the header translation with the pseudo
    translation tool.

    Change-Id: If9778f361d2bb1682e258578b7525bb734b8f8b6
    Closes-Bug: 1485778

Changed in horizon:
status: In Progress → Fix Committed
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.