cinder force_detach does not take a connector, so it is useless

Bug #1485766 reported by Scott DAngelo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Scott DAngelo

Bug Description

The function force_detach in cinder/api/contrib/admin_actions does not take a connector in the body of the request. When it calls terminate connection it passes in an empty dict as the connector:
    self.volume_api.terminate_connection(context, volume, {}, force=True)

The effect of this is that it does nothing, but might fool the user into thinking it does indeed force_detach. Before any other changes to cinder force_detach this must be fixed.

Changed in cinder:
assignee: nobody → Scott DAngelo (scott-dangelo)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/213867

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/213867
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6454429b82c8b9316293cf9e4b38d4067b8b72be
Submitter: Jenkins
Branch: master

commit 6454429b82c8b9316293cf9e4b38d4067b8b72be
Author: scottda <email address hidden>
Date: Mon Aug 17 21:36:18 2015 +0000

    force_detach terminate_connection needs connector

    The function force_detach in cinder/api/contrib/admin_actions does not
    take a connector in the body of the request. When it calls terminate
    connection it passes in an empty dict as the connector:
    self.volume_api.terminate_connection(context, volume, {}, force=True)
    This patch pulls the connector out of the body of the request, and
    throws an exception if it is missing.

    Change-Id: I14990eb4f42283231e4249a81d0b7fa18a8dfeae
    Closes-Bug:#1485766

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.