Keystone raises an exception when it receives incorrectly encoded parameters

Bug #1485694 reported by Sean Perry
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Sean Perry
keystone (Ubuntu)
Fix Released
Medium
James Page
Wily
Fix Released
Medium
James Page

Bug Description

The following command will cause an exception:

    $ curl -g -i -X GET http://localhost:35357/v3/users?name=nonexit%E8nt -H "User-Agent: python-keystoneclient" -H "Accept: application/json" -H "X-Auth-Token: "ADMIN

This command works as expected:

    $ curl -g -i -X GET http://localhost:35357/v3/users?name=nonexit%C3%A8nt -H "User-Agent: python-keystoneclient" -H "Accept: application/json" -H "X-Auth-Token: ADMIN"

The exception occurs fairly deep in the WebOb library while it is trying to parse the parameters our of the URL.

Revision history for this message
Sean Perry (sean-perry-a) wrote :
Revision history for this message
Sean Perry (sean-perry-a) wrote :

Patch to follow.

David Stanek (dstanek)
Changed in keystone (Ubuntu):
status: New → Confirmed
David Stanek (dstanek)
Changed in keystone:
status: New → Confirmed
importance: Undecided → Medium
Changed in keystone:
assignee: nobody → Sean Perry (sean-perry-a)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/213796
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=ef5f60305ce756a0832106ffa98a2314435a402d
Submitter: Jenkins
Branch: master

commit ef5f60305ce756a0832106ffa98a2314435a402d
Author: Sean Perry <email address hidden>
Date: Mon Aug 17 10:25:22 2015 -0700

    Prevent exception for invalidly encoded parameters

    An exception occurs in the WebOb library when it tries to decode a
    parameter that is not valid UTF8. To avoid this let's wrap the section
    using the WebOb code and raise a ValidationError so the user gets
    proper feedback instead of a UnknownError and a server 500 response.

    Change-Id: I6781770a6c5b317eaef84064ef61b9c838d22bc2
    Closes-Bug: 1485694

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → liberty-3
status: Fix Committed → Fix Released
James Page (james-page)
Changed in keystone (Ubuntu):
importance: Undecided → Medium
Changed in keystone (Ubuntu Wily):
status: Confirmed → In Progress
milestone: none → ubuntu-15.09
James Page (james-page)
Changed in keystone (Ubuntu Wily):
assignee: nobody → James Page (james-page)
James Page (james-page)
Changed in keystone (Ubuntu Wily):
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-3 → 8.0.0
Chuck Short (zulcss)
Changed in keystone (Ubuntu Wily):
status: Fix Committed → Fix Released
Changed in keystone (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.