backup init_host cleanup volume detach should be resilient and effective

Bug #1485295 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Tom Barron

Bug Description

In review https://review.openstack.org/#/c/210147/ for the fix for https://bugs.launchpad.net/cinder/+bug/1482548 two issues were raised that need to be fixed though they were outside the scope of that fix:

1. current code is not resilient to detach failures of a particular volume. On such failures it should skip DB update, and move onto the next volume.

2. current code simply issues 'detach_volume', which basically just updates the DB, rather than doing everything needed to actually detach the volume.

This bug is for followup action to address these remaining issues.

Tom Barron (tpb)
Changed in cinder:
assignee: nobody → Tom Barron (tpb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221889

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/221889
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bda6da1f8df44a64e8b320ebd8e2211197b6afeb
Submitter: Jenkins
Branch: master

commit bda6da1f8df44a64e8b320ebd8e2211197b6afeb
Author: Tom Barron <email address hidden>
Date: Wed Aug 26 16:07:00 2015 -0400

    backup init_host cleanup exception handling

    Current cleanup of leftover backups, volumes, and temporary
    volumes and snapshots is not resilient in the face of exceptions
    such as failures in detach operations.

    This commit adds appropriate try/except logic to this section
    of code, thereby ensuring that the backup service can start even
    if exceptions are encountered when attempting to cleanup detritus
    from earlier failed backup operations.

    Change-Id: Ie8d2107ebd4d86dfe5664c35687e8cbe58cfad9d
    Closes-bug: 1485295

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.