Style dark and light with css [$50]
Bug #1485270 reported by
Danielle Foré
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Wingpanel |
Fix Released
|
Wishlist
|
Marcus Wichelmann | ||
Bug Description
Instead of having the styling happen internally for the dark, light, and maximized states, it should be done in CSS. Wingpanel should simply toggle css classes for each of these states and let the theme do the right thing.
".color-light" and ".color-dark" are already being used by GtkColorSwatch, so I think we should stick to that convention.
".maximized" is being used by gtk.headerbar so might as well stick to that as well.
Related branches
lp:~wingpanel-devs/wingpanel/simplify-background-management
- Djax: Approve (code)
- Danielle Foré: Approve (ux)
- elementary Pantheon team: Pending requested
-
Diff: 539 lines (+161/-202)6 files modifiedsrc/PanelWindow.vala (+1/-5)
src/Services/BackgroundManager.vala (+31/-66)
src/Widgets/Panel.vala (+42/-53)
wingpanel-interface/AlphaManager.vala (+78/-61)
wingpanel-interface/DBusServer.vala (+9/-9)
wingpanel-interface/Main.vala (+0/-8)
| Changed in wingpanel: | |
| importance: | Undecided → Wishlist |
| Changed in wingpanel: | |
| status: | New → Confirmed |
| Changed in wingpanel: | |
| milestone: | none → loki-beta1 |
Revision history for this message
| Danielle Foré (danrabbit) wrote Re: Style dark and light with css [$15] | #1 |
| summary: |
- Style dark and light with css + Style dark and light with css [$15] |
| tags: | added: bounty |
| summary: |
- Style dark and light with css [$15] + Style dark and light with css [$50] |
| Changed in wingpanel: | |
| status: | Confirmed → In Progress |
| Changed in wingpanel: | |
| assignee: | nobody → Marcus Wichelmann (l-admin-3) |
| Changed in wingpanel: | |
| status: | In Progress → Fix Committed |
| milestone: | loki-beta1 → loki-alpha1 |
| Changed in wingpanel: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
https:/