lshw does not display cpu information correctly on aarch64

[Manoj Iyer]

On certain aarch64 systems lshw does not display cpu information correctly. It displays cpu0 and the any subsequent cpus are displayed as DISABLED. On a multi core aarch64 system lshw displays the following:

  *-core
       description: Motherboard
       physical id: 0
       capabilities: < Intentionally Removed >
     *-cpu:0
          description: CPU
          product: cpu
          physical id: 0
          bus info: cpu@0
     *-cpu:1 DISABLED
          description: CPU
          product: cpu
          physical id: 2
          bus info: cpu@1
     *-cpu:2 DISABLED
          description: CPU
          product: cpu
          physical id: 4
          bus info: cpu@2
     *-cpu:3 DISABLED
          description: CPU
          product: cpu
          physical id: 5
          bus info: cpu@3

Please consider the attached merge proposal for SRU in trusty.

[Impact]

 * When users run lshw on aarch64 systems the CPU information is not displayed correctly. It displays cpu0 and the any subsequent cpus are displayed as DISABLED. Please refer to bug description for details on output.

 * This bug can be fixed by adding code to handle the aarch64 case similar to the existing code for powerpc, x86, x64, ia64 etc. But, lshw upstream has done the work of adding support for s390 and aarch64. It will be better to backport those changes rather than using a bandaid fix for aarch64 in ubuntu.

[Test Case]

 * On an ubuntu aarch64 system run the command sudo lshw and look at the information displayed for cpu. Without the patch you should see that CPU 1-N will be DISABLED.

 * With the patch run lshw on aarch64 ubuntu system and you should see that it lists CPUs 1-N and display information about the CPU.

[Regression Potential]

 * Currently support for aarch64 is broken, so if a regression were to occur it could be in other archs. But, the changes introduced by this patch is to support aarch64 and s390 systems and those changes should not impact other archs.

 * This patch was tested on a 48 core aarch64 system running Trusty and found to work as expected. lshw package for wily and trusty were built and tested on an aarch64 system running Trusty.

[dann frazier (dannf)]

@Manoj: can you MP a fix for vivid before we do the trusty one? Basically like the wily one, but with the following changes:

 - Please drop the changes to s390x - it won't be supported in trusty, an SRUs should avoid unnecessary changes.
 - Please either drop the changes on arm32 *or* verify the bug on an arm32 platform and verify the fix there.
 - Please drop the arch-independent changes (i.e. cpu->setProduct(value))
 - Please drop the __ID("@(#) change at the top of the file - it is an unnecessary change.
 - Please make the new patch the last entry in the debian/patches/series file
 - Please add a debian/changelog entry - ideally copying the one from wily, but with an LP bug reference.

Once we SRU the vivid one, we can move on to trusty with the same above changes.

[Brian Murray (brian-murray)]

Hello Manoj, or anyone else affected,

Accepted lshw into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lshw/02.17-1.1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris J Arges (arges)]

Hello Manoj, or anyone else affected,

Accepted lshw into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lshw/02.16-2ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Manoj Iyer (manjo)]

With the fix from proposed installed I can list CPUs correctly.

ubuntu@ubuntu:~$ apt-cache policy lshw
lshw:
  Installed: 02.16-2ubuntu1.3
  Candidate: 02.16-2ubuntu1.3
  Version table:
 *** 02.16-2ubuntu1.3 0
        500 http://ports.ubuntu.com/ubuntu-ports/ trusty-proposed/main arm64 Packages
        100 /var/lib/dpkg/status
     02.16-2ubuntu1.2 0
        500 http://ports.ubuntu.com/ubuntu-ports/ trusty-updates/main arm64 Packages
     02.16-2ubuntu1 0
        500 http://ports.ubuntu.com/ubuntu-ports/ trusty/main arm64 Packages
ubuntu@ubuntu:~$

ubuntu@ubuntu:~$ sudo lshw
[sudo] password for ubuntu:
ubuntu
    description: Computer
    product: < intentionally removed >
    width: 64 bits
  *-core
       description: Motherboard
       physical id: 0
       capabilities: cavium_thunder-88xx
     *-cpu:0
          description: CPU
          product: cpu
          physical id: 0
          bus info: cpu@0
          capabilities: fp asimd aes pmull sha1 sha2 crc32
     *-cpu:1
          description: CPU
          product: cpu
          physical id: 2
          bus info: cpu@1
          capabilities: fp asimd aes pmull sha1 sha2 crc32
     *-cpu:2
          description: CPU
          product: cpu
          physical id: 4
          bus info: cpu@2
          capabilities: fp asimd aes pmull sha1 sha2 crc32

[Manoj Iyer (manjo)]

For vivid:

ubuntu@ms10-33XXX:~$ sudo apt-cache policy lshw
lshw:
  Installed: 02.17-1.1ubuntu1.1
  Candidate: 02.17-1.1ubuntu1.1
  Version table:
 *** 02.17-1.1ubuntu1.1 0
        500 http://ports.ubuntu.com/ubuntu-ports/ vivid-proposed/main arm64 Packages
        100 /var/lib/dpkg/status
     02.17-1.1ubuntu1 0
        500 http://ports.ubuntu.com/ubuntu-ports/ vivid/main arm64 Packages

ubuntu@ms10-33-mcdivittB0:~$ sudo lshw
ms10-33-mcdivittb0
    description: Computer
    product: < removed >
    vendor: < removed >
    serial: < removed >
    width: 64 bits
  *-core
       description: Motherboard
       physical id: 0
       capabilities: < removed >
     *-firmware
          description: BootROM
          product: U02
          physical id: 1
          version: 02/26/2015
     *-cpu:0
          description: CPU
          product: cpu
          physical id: 2
          bus info: cpu@0
          capabilities: performance-monitor fp asimd evtstrm
     *-cpu:1
          description: CPU
          product: cpu
          physical id: 3
          bus info: cpu@1
          capabilities: performance-monitor fp asimd evtstrm

[Raghuram Kota (rkota)]

Hi Chris,
Manoj verfieid this for Trusty and Vivid (comms #4,#5). Please let us know if there is anything you need from us to complete this SRU.

Thanks,
Raghu

[Launchpad Janitor (janitor)]

This bug was fixed in the package lshw - 02.16-2ubuntu1.3

---------------
lshw (02.16-2ubuntu1.3) trusty-proposed; urgency=medium

  * Backport cpuinfo support for aarch64 (LP: #1485086)

 -- dann frazier <email address hidden> Fri, 28 Aug 2015 15:00:23 -0600

[Chris J Arges (arges)]

The verification of the Stable Release Update for lshw has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package lshw - 02.17-1.1ubuntu1.1

---------------
lshw (02.17-1.1ubuntu1.1) vivid; urgency=medium

  * Backport cpuinfo support for aarch64 (LP: #1485086)

 -- Manoj Iyer <email address hidden> Mon, 24 Aug 2015 16:11:32 -0500