Host Manager should use monitor metric objects

Bug #1485082 reported by Sudipta Biswas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Sudipta Biswas

Bug Description

Per bug 1468012 we changed the monitor metric reporting to use versioned Monitor Metric objects instead of plain old dictionaries.

This bug is being filed to address a code refactoring needed inside nova/scheduler/host_manager.py - in the _update_metrics_from_compute_node to use the monitor metric object instead of the current non object implementation.

Changed in nova:
assignee: nobody → Sudipta Biswas (sbiswas7)
tags: added: low-hanging-fruit
Changed in nova:
status: New → In Progress
Jay Pipes (jaypipes)
Changed in nova:
importance: Undecided → Low
Revision history for this message
Matt Riedemann (mriedem) wrote :

Simple code cleanup doesn't warrant a bug IMO.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/213317
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ae7dab9975bcbe3bb40cb9723b0deaed985b904c
Submitter: Jenkins
Branch: master

commit ae7dab9975bcbe3bb40cb9723b0deaed985b904c
Author: Sudipta Biswas <email address hidden>
Date: Sat Aug 15 01:15:08 2015 +0530

    Fix scheduler code to use monitor metric objects

    Per bug 1468012 we changed the monitor metric reporting
    to use versioned Monitor Metric objects instead of plain
    old dictionaries.

    This fix addresses a code refactoring needed inside
    nova/scheduler/host_manager.py - in the
    _update_metrics_from_compute_node to use the monitor metric object
    instead of the current non object implementation.

    Further, it fixes the metrics_filter.
    The metrics_filter was expecting a dict of metrics but now
    it has to adapt to the MonitorMetricList object instead.

    Closes-bug: 1485082
    Change-Id: I4dfbea27ce6c3eecc1a8658b1f9dc0feb2298705

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.