Don't make mongodb's MessageController depend on the private methods from QueueController
Bug #1484826 reported by
Flavio Percoco
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| zaqar |
Fix Released
|
High
|
Flavio Percoco | ||
Bug Description
Mongodb's MessageController implementation consumes private methods from the QueueController. This creates a dependency that prevents deployers to run Zaqar using mongodb for the data plane and something else for the control plane.
| Changed in zaqar: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Flavio Percoco (flaper87) |
| milestone: | none → liberty-3 |
| Changed in zaqar: | |
| status: | Confirmed → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to zaqar (master) | #1 |
| Changed in zaqar: | |
| status: | In Progress → Fix Committed |
| Changed in zaqar: | |
| status: | Fix Committed → Fix Released |
| Changed in zaqar: | |
| milestone: | liberty-3 → 1.0.0 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 1257e94a96d077b
Author: Flavio Percoco <email address hidden>
Date: Fri Aug 14 00:51:04 2015 +0200
Move _(get|inc)_counter out of QueueController
These 2 counter utilities are used in the message controller as a way to
paginate and guarantee FIFO. The counter was kept in the queue record
since it provides a centralized place for it to live in. However, since
we moved the QueueController to the control plane, we can't expect the
QueueController to be on the same sotrage as the MessageController.
The patch keeps the old methods around for backwards compatibility.
It'll check if the QueueController has these methods and call those
rather than the new ones to avoid reseting the counter. This should
eventually go away but for now, it's probably the best we can do.
Closes-bug: #1484826
Change-Id: I57a9c4baa1d6c9