Expanders in Site options are all ARIA-expanded by default

Bug #1484779 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
15.10
Fix Released
Undecided
Unassigned

Bug Description

In 15.10, the sections in Site options (/admin/site/options.php) use new Bootstrap expanders, with the ARIA-expanded attribute added for accessibility. However, on page load all the expanders have the attribute aria-expanded="1" despite being collapsed by default. This needs to be changed to aria-expanded="false" or equivalent.

Affects latest master

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5190

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5190
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/1e7ec190ee8034c756a77748f9f0c89c171db1bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1e7ec190ee8034c756a77748f9f0c89c171db1bd
Author: Jono Mingard <email address hidden>
Date: Fri Aug 28 15:09:12 2015 +1200

Fix aria-expanded attribute on pieforms fieldsets (Bug #1484779)

The attribute was being set in reverse (1 for collapsed, 0 for
expanded) so I've made it more explicit. Note this also fixes
various other pages (eg. "Settings" in "Add group") as well as the
reported bug

behatnotneeded

Change-Id: Id49fdca3db1d3585418179695b4ec60e6d3fc093

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.