innobackupex failing while trying to rsync missing temporary #sql* files

[Georgi Georgiev]

When using innobackupex with "--rsync" and the "LOCK TABLES FOR BACKUP" functionality the backup often fails with the following error:

------------
150804 10:31:11 Starting rsync as: rsync -t "/usr/local/lib/mysql5/" --files-from="/usr/local/lib/mysql5/tmp//xtrabackup_rsyncfiles_pass2" "/usr/local/mysql-backup/backup.0"
rsync: link_stat "/usr/local/lib/mysql5/tmp/#sql76f_a3f441_1a.MYD" failed: No such file or directory (2)
rsync: link_stat "/usr/local/lib/mysql5/tmp/#sql76f_a3f441_1a.MYI" failed: No such file or directory (2)
>> log scanned up to (1736882245244)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1165) [sender=3.1.0dev]
innobackupex: got a fatal error with the following stacktrace: at /usr/bin/innobackupex line 4263.
        main::backup_files(0) called at /usr/bin/innobackupex line 2003
        main::backup() called at /usr/bin/innobackupex line 1609
innobackupex: Error: rsync failed: No such file or directory at /usr/bin/innobackupex line 4263.
150804 10:31:11 innobackupex: Waiting for ibbackup (pid=6759) to finish
------------

The files in question which start with #sql are temporary MyISAM tables that were dropped after the list xtrabackup_rsyncfiles_pass2 had been created. Seems like the "LOCK TABLES FOR BACKUP" does not prevent the creating and dropping of temporary tables hence the rsync failures in pass2. I'm attaching a small patch that makes innobackupex skip temporary tables and solves the problem:

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-1342