Failure powering up nodes

[Ricardo Bánffy]

In the MAAS CI environment (running off trunk, r4185) we started getting power-up failures seemingly due to an extra space added to the node's IP address.

From cluster.log:

2015-08-13 04:26:25-0400 [-] Unhandled Error
 Traceback (most recent call last):
   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 423, in errback
     self._startRunCallbacks(fail)
   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 490, in _startRunCallbacks
     self._runCallbacks()
   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 577, in _runCallbacks
     current.result = callback(current.result, *args, **kw)
   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1155, in gotResult
     _inlineCallbacks(r, g, deferred)
 --- <exception caught here> ---
   File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1097, in _inlineCallbacks
     result = result.throwExceptionIntoGenerator(g)
   File "/usr/lib/python2.7/dist-packages/twisted/python/failure.py", line 389, in throwExceptionIntoGenerator
     return g.throw(self.type, self.value, self.tb)
   File "/usr/lib/python2.7/dist-packages/provisioningserver/drivers/power/__init__.py", line 278, in perform_power
     raise e
 provisioningserver.drivers.power.PowerFatalError: Failed to power on 10.245.143.105 : /usr/sbin/ipmi-chassis-config: invalid hostname

Full set of artifacts is attached to this bug report.

[Andres Rodriguez (andreserl)]

Power parameters are set like:

    "node-4e750024-419f-11e5-99c0-deadbeef6bb3": {
        "power_driver": "",
        "mac_address": "",
        "power_address": "10.245.143.104 ",
        "power_pass": "ubuntu",
        "power_user": "root"
    }

My guess is the trailing whitespace after power_address. However, this is a regression.... the ipmi power driver should not fail due to a trailing whitespacE?

[Gavin Panella (allenap)]

There is a schema to validate power parameters when they're set. I suggest we first check that that is doing the right thing before patching over the problem in the driver.

[Newell Jensen (newell-jensen)]

Gavin,

Didn't we discuss that this would be handled by MAAS closer to the database so that valid data is saved and the power parameters doesn't have to deal with this?

[Gavin Panella (allenap)]

> Didn't we discuss that this would be handled by MAAS closer to the
> database so that valid data is saved and the power parameters doesn't
> have to deal with this?

Yep, I think that's the best approach. For reference, my comments in https://code.launchpad.net/~newell-jensen/maas/fix-1484551/+merge/268029 have my thoughts, and my conclusion was:

-> We should *not* fix-up white-space issues in the driver.

-> We should tighten up validation of power parameters to help prevent
   bad data from getting in.

-> We should fix validation in the case of power_driver.