live_migration_flag nova.conf option only specified when ceph in use

[Matt Thompson]

Currently, live_migration_flag is only added to nova.conf if cinder_backends_rbd_inuse|bool or nova_libvirt_images_rbd_pool is defined. There may be other use cases where this is necessary so it should be moved out of the ceph conditional statement.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/212452

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/212452
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=b4d468ea22e23126c7924faf68df45598fd08e26
Submitter: Jenkins
Branch: master

commit b4d468ea22e23126c7924faf68df45598fd08e26
Author: Matt Thompson <email address hidden>
Date: Thu Aug 13 11:17:57 2015 +0100

    Add nova_libvirt_live_migration_flag variable

    Currently live_migration_flag is only written to nova.conf if Ceph is
    in use. However, there may be other use cases using live migrations
    where being able to override this is necessary. This commit introduces
    a new variable called nova_libvirt_live_migration_flag and writes
    live_migration_flag to nova.conf irrespective of whether Ceph is in
    use. We also relocate nova_libvirt_disk_cachemodes and
    nova_libvirt_hw_disk_discard in defaults/main.yml so that these
    defaults sit with the other nova_libvirt defaults.

    NOTE: We change the live_migration_flag defaults here to match nova's
          defaults. Several Ceph resources suggest to use
          VIR_MIGRATE_PERSIST_DEST however in my limited testing this did
          not appear to be necessary. We can update the default or amend
          it when using Ceph if we find that it is in fact necessary.

    Closes-Bug: #1484439
    Change-Id: I1baa9d590ae90ca45c763c8a5e6546c4825eabfe

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216428
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=2bec5f01a5a036367c3a25f762255656d4d9371a
Submitter: Jenkins
Branch: kilo

commit 2bec5f01a5a036367c3a25f762255656d4d9371a
Author: Matt Thompson <email address hidden>
Date: Thu Aug 13 11:17:57 2015 +0100

    Add nova_libvirt_live_migration_flag variable

    Currently live_migration_flag is only written to nova.conf if Ceph is
    in use. However, there may be other use cases using live migrations
    where being able to override this is necessary. This commit introduces
    a new variable called nova_libvirt_live_migration_flag and writes
    live_migration_flag to nova.conf irrespective of whether Ceph is in
    use. We also relocate nova_libvirt_disk_cachemodes and
    nova_libvirt_hw_disk_discard in defaults/main.yml so that these
    defaults sit with the other nova_libvirt defaults.

    NOTE: We change the live_migration_flag defaults here to match nova's
          defaults. Several Ceph resources suggest to use
          VIR_MIGRATE_PERSIST_DEST however in my limited testing this did
          not appear to be necessary. We can update the default or amend
          it when using Ceph if we find that it is in fact necessary.

    Closes-Bug: #1484439
    Change-Id: I1baa9d590ae90ca45c763c8a5e6546c4825eabfe
    (cherry picked from commit b4d468ea22e23126c7924faf68df45598fd08e26)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.