_reorder_devices put find devices in incorrect order

[Ann Taraday]

In _reorder_devices that was added as part of graceful OVS agent restart, devices can be added in incorrect order as ports can exist in port_tags without tags.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Ann Kamyshnikova <email address hidden>
Review: https://review.fuel-infra.org/10395

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/10395
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: ec2ef4d7f07ac3d1bfc02d2b678256e85dba64f6
Author: Ann Kamyshnikova <email address hidden>
Date: Thu Aug 13 12:05:15 2015

Fix _reoder_devices method

Added check that even if port exists in port_tags map it has tag.
Also dead ports that are marked with -1 tag will be processed as
other_devices.

This change also contains some refactor that was applied in upstream
and new unittests.

Closes-bug: #1484408

Change-Id: Ifa6a3ba536a5d0e512a995ab99f999efd1d715d7

[Anna Babich (ababich)]

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "7.0"
  openstack_version: "2015.1.0-7.0"
  api: "1.0"
  build_number: "252"
  build_id: "2015-08-29_17-24-57"
  nailgun_sha: "3189ccfb8c1dac888e351f535b03bdbc9d392406"
  python-fuelclient_sha: "9643fa07f1290071511066804f962f62fe27b512"
  fuel-agent_sha: "1e8f38bbb864ed99aa8fe862b6367e82afec3263"
  fuel-nailgun-agent_sha: "d7027952870a35db8dc52f185bb1158cdd3d1ebd"
  astute_sha: "53c86cba593ddbac776ce5a3360240274c20738c"
  fuel-library_sha: "f05b958ef318f70170fe0db71bffcbaadbc39ae4"
  fuel-ostf_sha: "83048d68609854324ceeaf04242e68d658cfb55d"
  fuelmain_sha: "0e54d68392b359bc122e5bbba9249c729eeaf579"

Verified on cluster: neutron+vxlan, 3 controllers, 2 computes

Verification scenario
1. Create four networks and launch two instances per each network
2. Run the command against master node:
for i in $(fuel node | grep '[0-9]' | awk '{print$1}'); do ssh node-$i ' ovs-vsctl show > before '; done
3. Run the script against master node:
#!/bin/bash
# $1 - controller on what we should disable agents
#Disable/enable ovs-agents on controllers
ssh root@$1 '. openrc && pcs resource disable p_neutron-plugin-openvswitch-agent'
ssh root@$1 '. openrc && pcs resource enable p_neutron-plugin-openvswitch-agent'
#Restart ovs-agents on computes
for i in $(fuel node | grep compute | awk '{print$1}'); do ssh node-$i 'service neutron-plugin-openvswitch-agent restart'; done
# wait restart
sleep 30
4. Run the command against master node:
for i in $(fuel node | grep '[0-9]' | awk '{print$1}'); do ssh node-$i 'ovs-vsctl show > after'; done
5. Check that tags didn't change their values with the command against master node:
for i in $(fuel node | grep '[0-9]' | awk '{print$1}'); do ssh node-$i 'diff before after > diff.log'; done

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Ann Kamyshnikova <email address hidden>
Review: https://review.fuel-infra.org/13312

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Ann Kamyshnikova <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/13312
Reason: This change was merged in upstream as part of https://review.openstack.org/#/c/182920/