XNAMatrixFromMSTSCoordinates returns NaN value for very-close coordinates

Bug #1484205 reported by Dennis A T
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Medium
Dennis A T

Bug Description

Under certain conditions involving vehicles less than 1mm in length, eg spacer/headboard/tailboard vehicles, XNAMatrix contains bad values. This causes OR to freeze, see http://www.elvastower.com/forums/index.php?/topic/27127-xnamatrixm32-returns-a-nan-value/.

A suggested patch to detect the zero divide condition that occurs in XNAMatrixFromMSTSCoordinates() is attached.

Revision history for this message
Dennis A T (dennisat) wrote :
Dennis A T (dennisat)
description: updated
James Ross (twpol)
summary: - XNAMatrix returns a NaN value
+ XNAMatrixFromMSTSCoordinates returns NaN value for very-close
+ coordinates
Changed in or:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Dennis A T (dennisat)
milestone: none → 1.1
Revision history for this message
Carlo Santucci (carlosanit1) wrote :

Dennis, I see that the bug has been assigned to you. Do you have the access rights to commit the patch? If not, I can do that, as I see that things don't move here :)

Revision history for this message
Dennis A T (dennisat) wrote :

Hi Carlo,

I'm still very much an amateur and have no developer rights.

In the last post on the "Maybe it's a bug" forum, James suggested that he or someone else who knew the area of concern should check the patch. I have presumed that it's been waiting for assignment to a qualified person to do the checks.

I've tested this as well as I'm able and have been running with it installed on my system since I produced the patch. I've noticed no adverse effects and had no crashes.

Because the crash only happened about once every 4 tests, I put a rather "Mickey Mouse" message in the patch to reassure me that when the conditions occurred the patch was working. This message probably doesn't need to be there if the patch goes live.

Dennis

Revision history for this message
Carlo Santucci (carlosanit1) wrote :

OK Dennis,
I've committed it in release x.3244 removing the trace line. Thank you for your contribution!

Changed in or:
status: Triaged → Fix Committed
James Ross (twpol)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.