Manila Client Lists "spec_driver_handles_share_servers" as Optional Parameter in Help

[Dustin Schoenbrun]

When exploring the Python Manila Client, I came across a bug in the help for the type-create command. The output of the help suggests that the "spec_driver_handles_share_servers" value is optional and can be omitted. By doing so, the command will fail, saying that the parameter is missing from the command line.

-- Output from type-create help --
manila help type-create
usage: manila type-create [--is_public <is_public>]
                          <name> [<spec_driver_handles_share_servers>]

Create a new share type.

Positional arguments:
  <name> Name of the new share type.
  <spec_driver_handles_share_servers>
                        Required extra specification. Valid values 'true'/'1'
                        and 'false'/'0'

Optional arguments:
  --is_public <is_public>, --is-public <is_public>
                        Make type accessible to the public (default true).

-- Output from Manila Client with No Value for spec_driver_handles_share_servers --
manila type-create test
ERROR: Argument spec_driver_handles_share_servers argument is not valid: Unrecognized value '', acceptable values are: '0', '1', 'f', 'false', 'n', 'no', 'off', 'on', 't', 'true', 'y', 'yes'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/212108

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/212108
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=5f45b18f3616c9e6e027698913405ff9e6dc1a59
Submitter: Jenkins
Branch: master

commit 5f45b18f3616c9e6e027698913405ff9e6dc1a59
Author: Dustin Schoenbrun <email address hidden>
Date: Wed Aug 12 11:38:39 2015 -0400

    Make spec_driver_handles_share_servers required

    This change makes the extra spec "spec_driver_handles_share_servers"
    required for the type-create command in the Manila Client as opposed
    to being listed as an optional argument that was in fact required. I
    had to remove a no longer valid test case in the unit test suite,
    but it was done because instead of throwing an exception, the
    argparser will just exit(2).

    Change-Id: I0dc58cdfe10493a8eb736fa1bd0cd196bb0f5c05
    Closes-Bug: #1484156